301463 - Move CheckFormField and CheckFormFieldDefined into Field.pm

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Frédéric Buclin]

These routines are used by post_bug.cgi and process_bug.cgi only.

Fields related stuff must go into the new Field.pm module.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Do we want to rename these routines to check_form_field and
check_form_field_defined?

Comment 2

[Max Kanat-Alexander]

Comment on attachment 189948 [details] [diff] [review]
patch, v1

Looks generally good on inspection, and the POD docs seem to have basically the
right structure.

There does need to be a =back at the end of each =head1 section.

Also, the function docs, since this is a new module, should be in our standard
Description/Params/Returns format. Product.pm is a pretty good example of this,
as I recall.

And yeah, we should rename the functions.

Eventually they will be methods of a Field object, but for now we'll just leave
them as they are.

Oh also, DESCRIPTION should probably be something more like, "Thi package
provides functions for dealing with CGI form fields."

Comment 3

[Frédéric Buclin]

Attachment: patch, v2

Comment 4

[Frédéric Buclin]

Attachment: patch, v2.1

Now that we have POD docs, comments are no longer required. :)

Comment 5

[Max Kanat-Alexander]

Comment on attachment 189957 [details] [diff] [review]
patch, v2.1

r=mkanat on inspection.

Comment 6

[Max Kanat-Alexander]

Comment on attachment 189957 [details] [diff] [review]
patch, v2.1

OK, still needs testing.

Comment 7

[Frédéric Buclin]

FYI, I did some additional testing using both post_bug.cgi and process_bug.cgi.
It works fine! :)

Comment 8

[Max Kanat-Alexander]

Comment on attachment 189957 [details] [diff] [review]
patch, v2.1

OK. I trust LpSolit's testing. :-)

Comment 9

[Dave Miller [:justdave]]

(In reply to comment #4)
> Created an attachment (id=189957) [edit]
> patch, v2.1
> 
> Now that we have POD docs, comments are no longer required. :)

On the contrary, POD docs are just another form of comments ;)  (just a little
more structured).

Comment 10

[Frédéric Buclin]

Checking in CGI.pl;
/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v  <--  CGI.pl
new revision: 1.250; previous revision: 1.249
done
Checking in post_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v  <--  post_bug.cgi
new revision: 1.119; previous revision: 1.118
done
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.266; previous revision: 1.265
done
RCS file: /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Field.pm,v
done
Checking in Bugzilla/Field.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Field.pm,v  <--  Field.pm
initial revision: 1.1
done