301489 - Palm sync does not build with latest platform SDK

Status: RESOLVED FIXED

(MailNews Core Graveyard :: Palm Sync, defect, P1)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

Palm sync does not build with the latest platform SDK

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

it hits this #error in a midl-generated proxy file:
#if !(TARGET_IS_NT40_OR_LATER)
#error You need a Windows NT 4.0 or later to run this stub because it uses these
features:
#error   -Oif or -Oicf.
#error However, your C/C++ compilation flags indicate you intend to run this app
on earlier systems.
#error This app will die there with the RPC_X_WRONG_STUB_VERSION error.
#endif

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

I'm using -Oic because
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/midl/midl/_target.asp
sounds to me like the other options require an NT-based windows, and I'm not
sure palmsync should be limited to that.

Comment 3

[Benjamin Smedberg]

Comment on attachment 189952 [details] [diff] [review]
patch

I would like this to get review by somebody who knows palmsync as well, but it
looks fine to me and does not look as if it will affect the actual interface
layout at all, only the stubbing.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 189952 [details] [diff] [review]
patch

ok... I don't know who knows palmsync these days, trying bienvenu :)

Comment 5

[David :Bienvenu]

Comment on attachment 189952 [details] [diff] [review]
patch

yep, palmsync is me.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 189952 [details] [diff] [review]
patch

fixes palmsync compilation with the latest sdk; should be low risk (just a
command-line argument change for midl)

requirement for turning on svg for seamonkey

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in build/Makefile.in;
/cvsroot/mozilla/mailnews/extensions/palmsync/build/Makefile.in,v  <--  Makefile.in
new revision: 1.8; previous revision: 1.7
done