301573 - E4X: Problems with entities

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Aiko]

User-Agent:       Mozilla/3.04 (WinNT; I)
Build Identifier: Up-to-date JS debug shell

This seems wrong:

js> <xml>&lt;</xml>
typein:1: SyntaxError: illegal XML character:
typein:1: <parent xmlns=''><xml><</xml></parent>
typein:1: .......................^
js> <xml>&amp;lt;</xml>
<
js> <xml>&amp;</xml>
typein:3: SyntaxError: unexpected end of XML entity:
typein:3: <parent xmlns=''><xml>&</xml></parent>
typein:3: ......................^

Expected output (as seen in Rhino) would be:

js> <xml>&lt;</xml>
<
js> <xml>&amp;lt;</xml>
&lt;
js> <xml>&amp;</xml>
&

Reproducible: Always

Steps to Reproduce:

Comment 1

[Wladimir Palant]

Confirmed. Note that the problem also occurs in XHTML documents within CDATA
sections so this can't be the HTML parser.

Comment 2

[Brendan Eich [:brendan]]

Ready to check in the fix I'm about to attach.

/be

Comment 3

[Brendan Eich [:brendan]]

Attachment: easy fix

mrbkap r'd, to the extent he didn't write the patch (to which extent, I'm r'ing
his work ;-).

/be

Comment 4

[Brendan Eich [:brendan]]

Fixed.

/be

Comment 5

[Aiko]

Verified fixed, thanks!

Comment 6

[Bob Clary [:bc] (inactive)]

Checking in regress-301573.js;
/cvsroot/mozilla/js/tests/e4x/Regress/regress-301573.js,v  <--  regress-301573.js