301579 - SeaMonkey installer closes Mozilla 1.7.x without warning

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

When installing seamonkey, the installer automatically closes a running Mozilla
1.7.8.

that's not nice. it shouldn't do that :-)

additionally, when starting seamonkey and mozilla 1.7.x is already running, it
opens a window there. it should be independent of mozilla. I suspect these two
issues are somewhat related.

Comment 1

[OstGote!]

SM and Moz share the profile like NS6-7 and Moz, similiar problems for that.

Comment 2

[[e-mail]]

config.it hard-codes MozillaWindowClass, but we actually use
@MOZ_APP_DISPLAYNAME@WindowClass

Comment 3

[[e-mail]]

To be precise, some of the .it files used by the (un)installer have been changed
from MozillaWindowClass to SeaMonkeyWindowClass - ideally they would all be
preprocessed to whatever magic string expands to @MOZ_APP_DISPLAYNAME@

As for the SeaMonkey opening a window in Mozilla, that's caused by a stale
module.rc - it needs to depend on module.ver milestone.txt and build_number.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #3)
> As for the SeaMonkey opening a window in Mozilla, that's caused by a stale
> module.rc - it needs to depend on module.ver milestone.txt and build_number.

ah yes. you are, of course, correct. (for anyone's reference: the one in
xpfe/bootstrap)

Comment 5

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

<biesi> so splash.res: splash.rc module.ver … ought to work in
xpfe/bootstrap/Makefile.in

Comment 6

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch

Use the right message window name.

Comment 7

[Robert Kaiser]

Comment on attachment 193118 [details] [diff] [review]
patch

obsolete patch per CTho's request, it's wrong (doesn't close 1.7.x but doesn't
close SeaMonkey either). Some $foo$ replacement needs to be used instead of
@MOZ_APP_DISPLAYNAME@

Comment 8

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch

This patch actually causes the right string ("SeaMonkeyMessageWindow") to show
up in the generated .ini files.

Comment 9

[Benjamin Smedberg]

Comment on attachment 193290 [details] [diff] [review]
patch

Since SeaMonkey is still going to be using existing Mozilla profiles, you
really should close old Mozillas (with a nice warning+cancel, of course).

Comment 10

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

I won't be able to get to this in the very-near future.

Comment 11

[Robert Kaiser]

This is an Alpha blocker - how are we going to tackle this and who is going to
fix this ASAP?

Comment 12

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Could we swap out the NS6-detection strings with Mozilla strings?  Would that
handle all the necessary situations?

Comment 13

[Christian :Biesinger (don't email me, ping me on IRC)]

can we add them in addition to the ns6 ones?

Comment 14

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch v2

Is this better?  I can't test it right now, but a build with it is
http://ctho.ath.cx/smtree2/mozbuild/dist/install/seamonkey-1.1a.en-US.win32.installer.exe

Comment 15

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch

This one actually works.

Comment 16

[Benjamin Smedberg]

Comment on attachment 195406 [details] [diff] [review]
patch

s/it's/its/

Comment 17

[Daniel Veditz [:dveditz]]

Comment on attachment 195406 [details] [diff] [review]
patch

sr=dveditz

Comment 18

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 195406 [details] [diff] [review]
patch

SeaMonkey-only patch needed for 1.0 alpha.

Comment 19

[Serge Gautherie (:sgautherie)]

Comment on attachment 195406 [details] [diff] [review]
patch

Nits !?

>Index: xpinstall/packager/build/win/mozilla/config.it
>===================================================================
>@@ -379,36 +379,54 @@ confirm_install=false
> [Check Instance0]
> ; These keys are not normally necessary for checking instances.  They are
> ; set here because Mozilla requires a way to shut down it's turbo mode.

$ProductName$ (or Seamonkey) !?

>Index: xpinstall/packager/build/win/mozilla/uninstall.it
>===================================================================
>@@ -52,30 +52,42 @@ Decrypt Main Key=TRUE
> [Check Instance0]
> ; These keys are not normally necessary for checking instances.  They are
>-; set here because Mozilla requires a way to shut down it's turbo mode.
>+; set here because SeaMonkey requires a way to shut down it's turbo mode.

(Why not $ProductName$ ?)

>Index: xpinstall/packager/win_gre/config.it
>===================================================================
>@@ -282,41 +282,64 @@ confirm_install=false
> [Check Instance0]
> ; These keys are not normally necessary for checking instances.  They are
> ; set here because Mozilla requires a way to shut down it's turbo mode.

$ProductName$ (or Seamonkey) !?

> Extra Cmd0 Reg Key=Software\Microsoft\Windows\CurrentVersion\App Paths\seamonkey.exe

(Why not $MainExeFile$ ?)

>Index: xpinstall/packager/win_gre/uninstall.it
>===================================================================
>@@ -55,19 +55,19 @@ Decrypt Main Key=TRUE
> [Check Instance0]
> ;*** LOCALIZE ME BABY ***
> Message=SeaMonkey is detected to be currently running.  Please quit SeaMonkey before continuing.  Click OK to exit SeaMonkey automatically and proceed with uninstallation.
> ;*** LOCALIZE ME BABY ***
> Message wait=Shutting down SeaMonkey.  Please wait...

(Why not $ProductName$ ? (there and probably after))

> ; This key indicates whether or not to close all the windows associated with

>Index: xpinstall/packager/windows/config.it
>===================================================================
>@@ -444,18 +444,41 @@ Close All Process Windows=TRUE
> 
> ; These keys are not normally necessary for checking instances.  They are
> ; set here because SeaMonkey requires a way to shut down it's turbo mode.

(Why not $ProductName$ ?)

> [Check Instance1]
>+; These keys are not normally necessary for checking instances.  They are
>+; set here because SeaMonkey requires a way to shut down it's turbo mode.

Mozilla !

>Index: xpinstall/packager/windows/uninstall.it
>===================================================================
>@@ -73,18 +73,39 @@ Close All Process Windows=TRUE
> ; These keys are not normally necessary for checking instances.  They are
> ; set here because Mozilla requires a way to shut down it's turbo mode.

$ProductName$ (or Seamonkey) !?

Comment 20

[Daniel Veditz [:dveditz]]

Comment on attachment 195406 [details] [diff] [review]
patch

a=dveditz for 1.8 branch [seamonkey-only code]

Comment 21

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Checked in on branch.

I did not address comment 19 on trunk or branch.  Hopefully we can switch to a
better installer for 1.9 anyway.

Comment 22

[Serge Gautherie (:sgautherie)]

(In reply to comment #21)
> I did not address comment 19 on trunk or branch.  Hopefully we can switch to a
> better installer for 1.9 anyway.

Does it mean I could be the one preparing the patch ?
Or is it a "don't waste anymore time on this" situation ?

Comment 23

[Adam Guthrie]

*** Bug 310413 has been marked as a duplicate of this bug. ***