Closed Bug 301688 Opened 19 years ago Closed 19 years ago

Disabled buttons shoudn't have a "default button" look&feel

Categories

(Core Graveyard :: GFX: Mac, defect, P2)

Product:
Core Graveyard
Component:
GFX: Mac
Platform:
PowerPC
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.8beta4

People

(Reporter: asaf, Assigned: asaf)

References

Details

(Keywords: polish)

Attachments

(2 files)

screenshot
25.10 KB, image/png
Details
patch
2.28 KB, patch
jaas
: review+
sfraser_bugs
: superreview+
benjamin
: approval1.8b4+
Details | Diff | Splinter Review 
It seems that at least on 10.4, the button 'adornment' overrides its 'state'.
The result is disabled buttons with a default-button-look.
Blocks: deermac
Status: NEW → ASSIGNED
Keywords: polish
Priority: -- → P2
Target Milestone: --- → mozilla1.8beta4
Attached image screenshot — 

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  

        Attachment #190112 -
        Flags: superreview?(sfraser_bugs)

        Attachment #190112 -
        Flags: review?(joshmoz)

    
    

    
  
Comment on attachment 190112 [details] [diff] [review]
patch

looks good, compiles, works fine

        Attachment #190112 -
        Flags: review?(joshmoz) → review+

        Attachment #190112 -
        Flags: superreview?(sfraser_bugs) → superreview+

    
  

        Attachment #190112 -
        Flags: approval1.8b4?

    
  

        Attachment #190112 -
        Flags: approval1.8b4? → approval1.8b4+

    
    

    
  
Checking in nsNativeThemeMac.cpp;
/cvsroot/mozilla/gfx/src/mac/nsNativeThemeMac.cpp,v  <--  nsNativeThemeMac.cpp
new revision: 1.40; previous revision: 1.39
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: