302080 - Mac products need to display EULA

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Josh Aas]

We need to display a EULA when users install Firefox and Thunderbird on Macs.
This bug isn't about how we do that, we just need to do it. This should block
all further releases as it is a legal liability for us.

Comment 1

[Mike Pinkerton (not reading bugmail)]

can't we do it as part of the disk image mounting process? this is what we used
to do i think.

Comment 2

[riscky]

Camino too right?

Josh here is the SKD for it...
ftp://ftp.apple.com/developer/Development_Kits/SLAs_for_UDIFs_1.0.dmg

Comment 3

[Simon Fraser [no longer active]]

FireStorm can generate the bits for a disk image that shows a EULA, iirc.

Comment 4

[Mark Mentovai]

I've already got this working, I just need to integrate it into the build.  Also
bug 257854, bug 283598, and Camino equivalent bug 180837.  Note localization imapct.

Comment 5

[Bruce Davidson]

Please could one of the legal people take a moment to explain the "legal
liability" that arises from not showing the EULA?

Showing an EULA (especially with lots of CAPITAL LETTERS AND OTHER SCARY LOOKING
STUFF) is deeply user unfriendly.

We should make sure that we are happy the extra legal security is worth the loss
of useability. This will damage the (valuable) perception that we're open, 
friendly and on the users' side. We'll look like corporate-ware with (often
draconian) EULAs, and people (who won't read the EULA) may just assume we're of
the same ilk and have something to hide.

Comment 6

[Josh Aas]

We are showing a EULA before we ship. Legal explanation not necessary. Sorry,
but it isn't an arguable point.

Comment 7

[riscky]

Bruce,

The legal "legal liability" issue was addressed in a bug long long ago... I even
question logic/rational the first time around... as I hated always having to
agree to the EULA each time I updated my nightly (Mozilla Suite at the time)...
I've wish the EULA would only pop-up on the first run after a major upgrade say
1.0.x to 1.5 or when a new user profile is created... however that isn't likely...

Comment 8

[Mark Mentovai]

Is the same EULA to be used both in official and unofficial ("DeerPark") builds?

Localization: only English and Japanese EULAs exist.  It looks now like the
Japanese build will get jp and en, and everything else will get en.

Comment 9

[Mark Mentovai]

I've got a new dmg packager that will handle this, bug 180837, bug 257854, and
bug 283958.  I need to work Jaguar support back in, since the Seamonkey builders
aren't budging.  I expect it to be ready in a day or two.

Comment 10

[Ludovic Hirlimann [:Usul]]

Isn't 286779 a dup ?

Comment 11

[Mark Mentovai]

Attachment: Mac packaging files

These are the EULA resources and dmg icons and backgrounds.  No provisions for
l10n yet.  The EULA is only available in en and jp, and per discussion with
Mike Beltzner, current installers only display the en EULA with English "click
here to accept" instructions and this message (in English) at the top:

FOR TRANSLATIONS OF THIS LICENSE INTO SELECTED LANGUAGES, PLEASE VISIT
WWW.MOZILLA.ORG/LICENSING.

These click-throughs behave identically.  I used the offical Mozilla Firefox
and Mozilla Thunderbird text for official builds.  Thunderbird unofficial
builds also use the official Mozilla Thunderbird text.	Unofficial Firefox
builds replace Mozilla Firefox with Deer Park (this will need to become Gecko
Browser on the trunk after branching, I suppose); Camino replaces it with
Camino.  I assume that this was the correct thing to do, but please verify
this.

For l10n of the dmg backgrounds, see bug 283598.  It would be nice to sidestep
the problem by eliminating the text altogether.

Comment 12

[Mark Mentovai]

Attachment: New Mac OS X disk image (.dmg) packager

This replaces make-diskimage.  A patch to make-diskimage (in the next patch
set) allows it to use the new tool to package disk images.  This new script
contains full support for resources, backgrounds, and icons, things which were
partially implemented or not fully functional in the old script.  It also
produces slightly smaller disk images than the old script, and ones that should
mount more quickly.

Comment 13

[Mark Mentovai]

Attachment: Use the new packager to package the new files

This patch updates packager.mk to use the new dmg packager directly.  Firefox
and Thunderbird are updated to inform the packager of their licenses and glitz
from the .tar.bz2 archive.  In-tree packaging support is added to Camino as
well.

This patch depends on the two preceding attachments.

Comment 14

[Josh Aas]

1) the blank png files for products other than Camino are intentional, right? I
just want to make sure they are placeholders.

2) Is there any way we can share the same licensing text file that other
platforms use so that when that text file gets updated it gets updated in both
locations at once? Can we build the .r file dynamically or avoid the .r altogether?

Comment 15

[Mark Mentovai]

(In reply to comment #14)
> 1) the blank png files for products other than Camino are intentional, right?
> I just want to make sure they are placeholders.

They're placeholders.  Artwork is being developed in bug 283598.  I made a
request for artwork for the unbranded products there too.

> 2) Is there any way we can share the same licensing text file that other
> platforms use so that when that text file gets updated it gets updated in both
> locations at once? Can we build the .r file dynamically or avoid the .r
> altogether?

In a word, formatting.

Each .r (except for the two Thunderbird versions) is different, to reflect the
different product names.  We COULD set up license.r.in files and transform them
with sed, but the styl resources would get messed up because they contain
indices into the text.  You'd lose the boldfacing.  It would get even uglier,
and quickly.

The packager is equipped to take a plain text file and build a resource from it,
but again, it's plain text and therefore ugly for the same reason.  Also, you'd
lose the "You are about to install PRODUCT" message, which is kind of nice.  You
wouldn't believe how much difference it makes when the title is emboldened.

The eventual goal would be to set the packager up to accept rtf (or something
else that's not plain text) input and turn it into a suitable .r.  It's not
there yet.

The source tree already contains one plain-text EULA for Firefox and one for
Thunderbird.  They look like ass when they're fed directly to the packager.

Comment 16

[Josh Aas]

My default view is column view, and when I agree to the license agreement, a
sized (squished) column view window opens instead of a window with a background.
We should get updated ds_stores to force a certain view.

Comment 17

[Josh Aas]

We might want a more boring but more intuitive name for the dmg packager than
"dimmidge". It isn't clear from debugging data what that means. Something like
"moz_dmg_packager" would clarify the build output significantly.

Comment 18

[Josh Aas]

Comment on attachment 192035 [details] [diff] [review]
New Mac OS X disk image (.dmg) packager

Please rename "dimmidge" to something more intuitive. With that done, r+.
Sorry, but I think this should be done on technical grounds. See comment 17.

Comment 19

[Josh Aas]

Note for anyone else trying this out:

you need to chmod 700 the disk image packaging script (named "dimmidge" right now)

Comment 20

[Mark Mentovai]

The .DS_Store files are fine, but there's an Apple bug that causes read-only
disks to use the column view if that pref is set in certain circumstances. 
Fortunately, there's already a workaround in the packager.  In dimmidge (or
whatever it'll be called), we need to set 'makehybrid' => 0, and then to work
around another Apple bug, 'partition_table' => 1.

Comment 21

[Josh Aas]

Comment on attachment 192036 [details] [diff] [review]
Use the new packager to package the new files

looks good, tested on Firefox and Thunderbird

Comment 22

[Simon Fraser [no longer active]]

Comment on attachment 192035 [details] [diff] [review]
New Mac OS X disk image (.dmg) packager

rs=me

Comment 23

[Mark Mentovai]

Comment on attachment 192035 [details] [diff] [review]
New Mac OS X disk image (.dmg) packager

This will go in with the above changes under the name package-dmg, or something
else suitably boring.

Comment 24

[Mark Mentovai]

Comment on attachment 192033 [details]
Mac packaging files

The artwork will change, see bug 283598.  There's nothing wrong with the
artwork in this archive, it's just not l10n-friendly and the dmg backgrounds
for unofficial builds are intentionally blank.

Comment 25

[Mark Mentovai]

Attachment: Consolidated patch

For reference, the consolidated and updated code portion.  This is ready for
checkin on the trunk and, pending approval, the branch.  Applies cleanly to
each.  Changes noted above are included in this patch.	Two previously missing
diffs to makefiles in other-licenses are included.  An attribute-setting option
is added to the packager; it is only used by Camino at the moment to turn off
the display of extensions on the two read-me files included in its dmg.  The
Camino background's filename has changed to match the change in format from png
to jpg.  The new Camino artwork is in attachment 192657 [details]; an accompanying
.DS_Store file has been generated.  The other packaging files in the archive
are still current, for the time being.

Comment 26

[Mark Mentovai]

Fixed on trunk.  Leaving open for 1.8.

Comment 27

[Mark Mentovai]

Checked in to 1.8 branch.

Comment 28

[Tracy Walker [:tracy]]

Verified on Mac DP 2005-08-19-08-mozilla1.8

Comment 29

[Martin Creutziger [:MMx]]

This checkin seems to have caused a major regression, see bug 305470