302213 - Embedded mailto: URLs are broken in mail

Status: VERIFIED FIXED

(MailNews Core :: Networking, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Build ID: 2005-07-26-05, Windows XP SeaMonkey trunk.

Not sure if your checkin to bug 244964 merely exposed an underlying problem, or
if it broke this outright...

Summary: Embedded mailto: URLs are broken in mail.

Steps to Reproduce:

1. Click on any <a href="mailto:[e-mail]"> link in mail.

Actual Results:

The file "[e-mail]" is of type
application/x-java-applet;jpi-version=1.5.0_04, and SeaMonkey does not know how
to handle this file type.  This file is located at:

mailto:

What should SeaMonkey do with this file?

* Open it with the default application
* Open it with ________________ Choose...
* Save it to disk
[ ] Always perform this action when handling files of this type

Expected Results:

Just launch a mail compose window.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Stephen, what makes you think this has anything to do with the checkin for bug
244964?

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

[12:15] <DavidBienvenu> yup
[12:15] <DavidBienvenu> I updated in netwerk, and now I can't do mailto links -
Thx, Stephen! :-)

Comment 3

[Boris Zbarsky [:bzbarsky]]

So the problem is that the mailto protocol handler creates an input stream
channel as follows:

  357   return NS_NewInputStreamChannel(_retval, aURI, pipeIn,
  358                            NS_LITERAL_CSTRING("x-application-mailto"));

That's not a valid content-type (no '/' in it).  NS_ParseContentType used to not
care and just set that as the type; the new code, just like the old HTTP header
code, ignores the bogus type.

So a wallpaper fix would be to use something like "application/x-mailto" instead.

The real fix would be to not use a fake type here at all -- as things stand a
site can cause a mail compose window to pop up by just returning data with the
"right" content type.  Is there a reason not to open the compose window from
AsyncOpen (with an appropriate channel impl, of course)?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Actually, I was wrong.  It's even worse.  Mailnews will actually throw on
non-mailto: URIs that happen to have the type it's using, which ends up with no
feedback for the user as to why their click did nothing...  So once we fix this,
I'll definitely file a followup but for mailnews to stop using a type here.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

> site can cause a mail compose window to pop up by just returning data with the
> "right" content type.

of course they can also do location.href="mailto:[e-mail]"...

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

and the code does have the maybe nice feature that asyncOpen has no
side-effects. so things like wbp should not trigger opening of compose windows.
which might the reason why it's implemented as is, re:
> Is there a reason not to open the compose window from
> AsyncOpen (with an appropriate channel impl, of course)?

Comment 7

[Boris Zbarsky [:bzbarsky]]

> so things like wbp should not trigger opening of compose windows.

True, but we need to fix that for various other protocols anyway, at which point
mailto: should just use the "no data" protocol flag and stop doing what it does now.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed fix

Comment 9

[David :Bienvenu]

Comment on attachment 190597 [details] [diff] [review]
Proposed fix

thanks, Boris.

Comment 10

[Darin Fisher]

Comment on attachment 190597 [details] [diff] [review]
Proposed fix

A #define for the mime type would be nice, but this works.  sr=darin

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 190597 [details] [diff] [review]
Proposed fix

Requesting approval for simple regression fix.

Comment 12

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 190597 [details] [diff] [review]
Proposed fix

a=shaver

Comment 13

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using build 2005-07-27-05 on Windows XP SeaMonkey trunk.

Comment 15

[Boris Zbarsky [:bzbarsky]]

Filed followup bug 302661