302245 - Language pack listbox is full of (needs update) items

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[u60234]

Zip build Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4)
Gecko/20050726 SeaMonkey/1.0a

The list of available language packs in Appearance -> Languages/Content is full
of nameless locales with only the (needs update) hint visible. This seems to be
the Reporter locales that lack the "chrome:displayName="[language](CC)"
description line in their contents.rdf.

The current language, "English(US)", is also sorted to the bottom of the list
and is sometimes invisible, probably depending on font size.

This breaks language pack switching since a newly installed language pack is put
at the bottom of the list and can be out of view. I can still select it with the
keyboard, but the selected item is not visible.

Is there no way to prevent extension locales from populating this list of
application language packs?

Comment 1

[Klaus P. Kuhlemann]

Same on linux 20050730 gtk1 build. Install of a german language file was
possible, but sometimes not successful to switch to it. I saw this on linux, not
on windows 2000, XP and 98SE with 200507306installer.exe.
It's a regression.

Comment 2

[Robert Kaiser]

I think we might not want to ship the Alpha with that.

This might be caused by inspector and reporter shipping a lot of locales that
don't have a real locale name or global/ package installed and so might show up
without a name and with "(needs update)" in the language selection.

I ponder to exclude building languages other than en-US for suite.

bsmedberg, might you approve of that? Or do you have a better proposal to solve
that?

Comment 3

[Stefan [:stefanh]]

The issue is there in SeaMonkey 2005072214, but not in 2005072110. Must have
been caused by bug 299286.

Comment 4

[Benjamin Smedberg]

Robert, I don't know how the seamonkey locale selector works precisely, but it
should probably only look for locales with a global/ package, not any locale...
otherwise any extension that ships multiple locales could cause this problem.

Comment 5

[Robert Kaiser]

(In reply to comment #4)
> Robert, I don't know how the seamonkey locale selector works precisely, but it
> should probably only look for locales with a global/ package, not any locale...
> otherwise any extension that ships multiple locales could cause this problem.

The template that fetches the list from chrome registry is at
http://lxr.mozilla.org/mozilla/source/extensions/content-packs/resources/content/pref-contentpacks.xul#196

And actually, it fetches all languages registered in the chrome registry.
As I'm neither an expert an chromereg nor on tempaltes, do you have a suggestion
how we can solve this?

Additionally, I fear that with including all those locales with the new locale
codes, we may clash with content packs anyways, e.g. the new "pl" locale might
clash with a "PL" content pack...
Or is chromereg case-sensitive?

Comment 6

[Benjamin Smedberg]

It had better be case sensitive.

Comment 7

[[e-mail]]

Attachment: Proposed patch

This makes it so that we only list content packs with a global version.
Unfortunately I had to change to extended template syntax;
simple template syntax can't match on existence of an arc.

Comment 8

[Robert Kaiser]

Comment on attachment 191539 [details] [diff] [review]
Proposed patch

I don't understand template syntax (none of both) very well, but I can affirm
it works well here and I trust Neil to code it correctly, so r+ as long as jag
OKs the template stuff on sr :)

Comment 9

[[e-mail]]

Attachment: Trimmed patch

jag pointed out that I don't need to convert the first two rules.

Comment 10

[[e-mail]]

Fix checked in.

Comment 11

[Frank Wein [:mcsmurf]]

Comment on attachment 191539 [details] [diff] [review]
Proposed patch

cancel obsolete review request

Comment 12

[tech]

I've got the same problem on the very last version of mozilla suite (Mozilla/5.0 (Windows; U; Win98; fr-FR; rv:1.7.12) Gecko/20060205)
I tried to apply the given patch but it doesn't change anything
the bug isn't fixed
REOPEN

Comment 13

[Robert Kaiser]

if it's fixed on trunk (i.e. SeaMonkey), then it's correct status is RESOLVED FIXED.
If it has no fixed1.7 keyword, it's not fixed on Mozilla 1.7.x, which is the case here. As there's no further development (other than security fixes) on 1.7.x branch, this will not change.
You'll have to use SeaMonkey if you want a suite with that fix.

Comment 14

[tech]

(In reply to comment #13)
> if it's fixed on trunk (i.e. SeaMonkey), then it's correct status is RESOLVED
> FIXED.
> If it has no fixed1.7 keyword, it's not fixed on Mozilla 1.7.x, which is the
> case here. As there's no further development (other than security fixes) on
> 1.7.x branch, this will not change.
> You'll have to use SeaMonkey if you want a suite with that fix.
> 
does the patch provided here could fix the problem for my current version ?
if I modifiy the pref-contentpacks.xul from the content-packs.jar installed accordingly to the patch, could the bug in mozilla be corrected ?

Comment 15

[Hermann Schwab]

(In reply to comment #12)
> I've got the same problem on the very last version of mozilla suite
> (Mozilla/5.0 (Windows; U; Win98; fr-FR; rv:1.7.12) Gecko/20060205)
> I tried to apply the given patch but it doesn't change anything
> the bug isn't fixed
> REOPEN
> 

As can be seen in comment #3 this bug was a regression from Bug 299286
Move reporter and DOMI locale files from en-US.jar to reporter.jar/inspector.jar
This regressed in ... rv:1.8b4) Gecko/20050726 SeaMonkey/1.0a, and the patches for both bugs were approved for 1.8b4 only, so it is unlikely that patch applies to a 1.7.x build, as the first one is also missing.
Please update to seamonkey 1.0:
http://releases.mozilla.org/pub/mozilla.org/seamonkey/releases/1.0/
http://releases.mozilla.org/pub/mozilla.org/seamonkey/releases/1.0/contrib-localized/
I don't know why there is no french translation.

Comment 16

[tech]

(In reply to comment #15)
> As can be seen in comment #3 this bug was a regression from Bug 299286
> Move reporter and DOMI locale files from en-US.jar to
> reporter.jar/inspector.jar
> This regressed in ... rv:1.8b4) Gecko/20050726 SeaMonkey/1.0a, and the patches
> for both bugs were approved for 1.8b4 only, so it is unlikely that patch
> applies to a 1.7.x build, as the first one is also missing.
> Please update to seamonkey 1.0:
> http://releases.mozilla.org/pub/mozilla.org/seamonkey/releases/1.0/
> http://releases.mozilla.org/pub/mozilla.org/seamonkey/releases/1.0/contrib-localized/
> I don't know why there is no french translation.
> 
thanks I'm trying it.
I've found the fr xpi there http://frenchmozilla.sourceforge.net/FTP/SeaMonkey/1.0/seamonkey-1.0.fr-FR.langpack.xpi
but the translation is incomplete, some menu entries are missing, and the text under the button is in english

Comment 17

[tech]

(In reply to comment #15)
On your advice, I installed the http://releases.mozilla.org/pub/mozilla.org/seamonkey/releases/1.0/

but I regret it very much as it seems to be a whole regression it contains many many bugs that had disappeared



> (In reply to comment #12)
> > I've got the same problem on the very last version of mozilla suite
> > (Mozilla/5.0 (Windows; U; Win98; fr-FR; rv:1.7.12) Gecko/20060205)
> > I tried to apply the given patch but it doesn't change anything
> > the bug isn't fixed
> > REOPEN
> > 
> 
> As can be seen in comment #3 this bug was a regression from Bug 299286
> Move reporter and DOMI locale files from en-US.jar to
> reporter.jar/inspector.jar
> This regressed in ... rv:1.8b4) Gecko/20050726 SeaMonkey/1.0a, and the patches
> for both bugs were approved for 1.8b4 only, so it is unlikely that patch
> applies to a 1.7.x build, as the first one is also missing.
> Please update to seamonkey 1.0:
> http://releases.mozilla.org/pub/mozilla.org/seamonkey/releases/1.0/
> http://releases.mozilla.org/pub/mozilla.org/seamonkey/releases/1.0/contrib-localized/
> I don't know why there is no french translation.
> 

Comment 18

[tech]

(In reply to comment #15)
> As can be seen in comment #3 this bug was a regression from Bug 299286
> Move reporter and DOMI locale files from en-US.jar to
> reporter.jar/inspector.jar
> This regressed in ... rv:1.8b4) Gecko/20050726 SeaMonkey/1.0a, and the patches
> for both bugs were approved for 1.8b4 only, so it is unlikely that patch
> applies to a 1.7.x build, as the first one is also missing.
> Please update to seamonkey 1.0:
> http://releases.mozilla.org/pub/mozilla.org/seamonkey/releases/1.0/
> http://releases.mozilla.org/pub/mozilla.org/seamonkey/releases/1.0/contrib-localized/
> I don't know why there is no french translation.
> 
I just installed the last mozilla 1.7.13 release candidate so it seems that there still is a development on this branch and I got again the langages menu filled with noname entries with (need updates)
Still not fixed ?

Comment 19

[Robert Kaiser]

A security release like 1.7.13 (and yes, this will really be the last release of the Mozilla Suite - ever) does not mean active development.

By the way, the french version of SeaMonkey is available already as well.