302402 - Source links in JavaScript console open twice

Status: VERIFIED FIXED

(Core Graveyard :: Error Console, defect)

Description

[Jesse Ruderman]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050727
Firefox/1.0+

Steps to reproduce:
1. Load any page that results in an error in the JavaScript console, such as
http://www.google.com/.
2. Open the JavaScript console.
3. Click the link in an error message.

Result: Source code opens in two Firefox windows.  One scrolls to the correct
position and the other does not.

Comment 1

[Jesse Ruderman]

Also happens with the "Visit home page" link in an extension's About window.  I
wonder if this bug is a regression from Aaron's recent work with XUL hyperlinks
(e.g. in bug 301398).

Comment 2

[Aaron Leventhal]

It must be from me.

Comment 3

[Jesse Ruderman]

I see this bug in a July 27 nightly but not in a July 25 nightly.

Comment 4

[Gary Elshaw]

Just confirming it's still there for Mozilla/5.0 (Macintosh; U; PPC Mac OS X
Mach-O; en-US; rv:1.8b4) Gecko/20050728 Firefox/1.0+

Is it just me or is there some doubling up of the errors in the javascript
console itself too?

Comment 5

[Aaron Leventhal]

Attachment: 1) about extension link doesn't need onclick since href takes care of opening the link, 2) js console links need to prevent default since they have a special way of opening to a specific line #

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Same for Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050730
Firefox/1.0+

HW, OS => ALL

Comment 7

[Aaron Leventhal]

*** Bug 303082 has been marked as a duplicate of this bug. ***

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 190945 [details] [diff] [review]
1) about extension link doesn't need onclick since href takes care of opening the link, 2) js console links need to prevent default since they have a special way of opening to a specific line #

>     <handlers>
>-      <handler event="click" button="0"><![CDATA[
>+      <handler event="click" phase="capturing" button="0"><![CDATA[
>+          event.preventDefault();

You can just add preventdefault="true" to the handler here.  It'd also be nice 
if you could move <![CDATA[ onto its own line.

>Index: toolkit/content/widgets/text.xml
>===================================================================
>RCS file: /cvsroot/mozilla/toolkit/content/widgets/text.xml,v
>retrieving revision 1.15
>diff -p -u -5 -r1.15 text.xml
>--- toolkit/content/widgets/text.xml	20 Jul 2005 08:40:13 -0000	1.15
>+++ toolkit/content/widgets/text.xml	29 Jul 2005 13:41:49 -0000
>@@ -291,21 +291,24 @@
>       </property>
>       <property name="href" onget="return this.getAttribute('href');"
>                             onset="this.setAttribute('href', val); return val;" />
>     </implementation>
>     <handlers>
>-      <handler event="click">
>+      <handler event="click" phase="capturing" button="0">
>       <![CDATA[
>+        if (event.getPreventDefault()) {
>+          return;
>+        }

please drop the extra brackets, I know we're inconsistent sometimes, but
there's two other examples in the same function.

Comment 9

[Aaron Leventhal]

Checking in toolkit/components/console/content/consoleBindings.xml;
/cvsroot/mozilla/toolkit/components/console/content/consoleBindings.xml,v  <-- 
consoleBindings.xml
new revision: 1.9; previous revision: 1.8
done
Checking in toolkit/content/widgets/text.xml;
/cvsroot/mozilla/toolkit/content/widgets/text.xml,v  <--  text.xml
new revision: 1.17; previous revision: 1.16
done
Checking in toolkit/mozapps/extensions/content/about.xul;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/about.xul,v  <--  about.xul
new revision: 1.7; previous revision: 1.6
done

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Works fine with current CVS build Mozilla/5.0 (X11; U; Linux i686; en-US;
rv:1.8b4) Gecko/20050805 Firefox/1.0+