Closed
Bug 302412
Opened 20 years ago
Closed 20 years ago
Brendan's comments on my jsopcode changes
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mrbkap, Assigned: mrbkap)
Details
Attachments
(1 file)
|
11.67 KB,
patch
|
brendan
:
review+
brendan
:
approval1.8b4+
|
Details | Diff | Splinter Review |
Brendan made some comments on IRC that I'll address in this bug.
<brendan> you need to QuoteString(..., 0) even when inXML, to escape non-ASCII
<brendan> another thing (nit): JSOP_JSEXPR does not match naming conventions,
and repeats JS, which is otiose
<brendan> oh, and i thought we could use 0 prec(edence) for the bytecodes that
set op = JSOP_NOP; /* turn off parens */
Brendan also wondered about nested XML expressions in tag expressions (such as
<xml>{<lmx>{e}</lmx>}</xml>) but through the magic of JSOP_TOXML, we do the
correct thing.
|
Assignee | |
Comment 1•20 years ago
|
||
Attachment #190773 -
Flags: review?(brendan)
|
|
Assignee | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
Summary: Brendan's comments on my jsopcode changes → Brendan's comments on my jsopcode changes
|
||
Comment 2•20 years ago
|
||
Comment on attachment 190773 [details] [diff] [review]
pick the nits and fix the error
r+a=me, righteous!
/be
Attachment #190773 -
Flags: review?(brendan)
Attachment #190773 -
Flags: review+
Attachment #190773 -
Flags: approval1.8b4+
|
|
Assignee | |
Comment 3•20 years ago
|
||
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Flags: testcase-
You need to log in
before you can comment on or make changes to this bug.
Description
•