302781 - Splash screen should fade in on Windows

Status: VERIFIED FIXED

(SeaMonkey :: General, enhancement)

Description

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

The splash screen should fade in.

Comment 1

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch

Comment 2

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: better patch

Define constants myself as suggested by Neil, so we don't have to
#define _WIN32_WINNT 0x0500

Comment 3

[[e-mail]]

Comment on attachment 191059 [details] [diff] [review]
patch

>+#define _WIN32_WINNT 0x0500
You can't require the PSDK.

>+typedef BOOL (WINAPI *tSETLAYEREDWINDOWATTRIBUTESPROC)(HWND, COLORREF, BYTE, DWORD);
The Netscape style was to generate the type name from the function name by
prefixing NS_ although you might prefer to prefix MOZ_ instead.

>+    bool rv = (mSetLayeredWindowAttributesProc)(hwnd, 0, mOpacity, LWA_ALPHA);
>+    if (!rv)
>+        printf("SetLateredWindowAttributes failed: %d.\n", rv);
Can't printf, use NS_WARN_IF FALSE if you must, but note that rv is always 0 in
the printf...

Comment 4

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch

Addresses Neil's comments here and on IRC.

Comment 5

[[e-mail]]

Comment on attachment 191146 [details] [diff] [review]
patch

>+nsSplashScreenWin::TimerProc(HWND hwnd, UINT uMsg, UINT_PTR idEvent, DWORD dwTime) {
Nit: Style in this file seems to be to use HWND dlg as the window handle.

>+                SetTimer(dlg, 0, 5, TimerProc);
I think this value is a little small. Apparently XP does support timers with a
resolution of better than 55ms but its minimum is supposedly now 15ms (although
since there are only four hits in all of google I can't corroborate this).

Comment 6

[Ere Maijala (slow)]

Comment on attachment 191146 [details] [diff] [review]
patch

I agree with Neil regarding the timer value, but this is ok to me anyway.
r=emaijala

Comment 7

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 191146 [details] [diff] [review]
patch

SeaMonkey-only patch

Comment 8

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

I checked it in with a delay of 10, the minimum on Server 2003 (based on PSDK
headers).  If this is in fact below the minimum time for any of the other OSes
this applies to, they'll just use the minimum time which should still be fine.

Comment 9

[Marius Strumyla]

[offtopic] I think I saw somewhere in bugzilla mentioned that ns stands for
namespace rather than netscape.

Comment 10

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

This set Creature on fire.

c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpfe/bootstrap/nsNativeAppSupportWin.cpp(545)
: error C2065: 'SetWindowLongPtr' : undeclared identifier
c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpfe/bootstrap/nsNativeAppSupportWin.cpp(546)
: error C2065: 'GetWindowLongPtr' : undeclared identifier
c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpfe/bootstrap/nsNativeAppSupportWin.cpp(549)
: error C2664: 'SetTimer' : cannot convert parameter 4 from 'void (__stdcall
*)(struct HWND__ *,unsigned int,unsigned long,unsigned long)' to 'void
(__stdcall *)(struct HWND__ *,unsigned int,unsigned int,unsigned long)'
        This conversion requires a reinterpret_cast, a C-style cast or
function-style cast

Comment 11

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Checked in fixed version (Neil's suggestions worked).

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED with build 2005-10-13-16 on Windows XP SeaMonkey trunk.