303006 - [FIX]ASSERTION: Placeholder relationship should have been torn down

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[Bob Clary [:bc] (inactive)]

ASSERTION: Placeholder relationship should have been torn down:
'!shell->FrameManager()->GetPlaceholderFrameFor(mOutOfFlowFrame)', file
c:/work/mozilla/builds/ff/trunk/mozilla/layout/generic/nsPlaceholderFrame.cpp,
line 96

Found using a CVS debug build from 7/31 on WinXP during top site testing of 5469
pages. It appears to be new although I don't have good history of logs for full
top site testing.

I doubt this is related to the splitwindow bug, but ccing jst just in case.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Any idea which URL this might have been on?

Comment 2

[Bob Clary [:bc] (inactive)]

Sorry, I thought I had included them. These were found in the full top site
scan. (* - reproducible loading individual pages)

<http://www.amazon.com/exec/obidos/tg/browse/-/172282/ref=sd_allcatpop_el/103-8516287-7640622>
*<http://shop.lycos.com/>
*<http://msn.careerbuilder.com/PLI/R/FindJobs.htm?siteid=CBMSNBC017> (lots)
*<http://www.nytimes.com/adx/bin/adx_click.html?type=goto&page=homepage.nytimes.com/indexnew.html&pos=TopRight&camp=nwmutual12-nyt1&ad=184x901.gif&goto=http://www.nmfn.com>

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 193228 [details] [diff] [review]
Fix

>+    aFrameIn = nsPlaceholderFrame::GetRealFrameFor(placeholder);

Use GetRealFrameForPlaceholder since you already did the GetType check, and
r+sr=dbaron.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Fixed, with that change.