303361 - <menulist> object contains wrong implementation of "disabled" attribute

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Marek Lewczuk]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl-PL; rv:1.7.10) Gecko/20050717 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; pl-PL; rv:1.7.10) Gecko/20050717 Firefox/1.0.6

"disabled" is implemented in wrong way: onget="return
this.hasAttribute('disabled');" - this implementation means that if attribute
"disabled" is defined but is empty or with value "false", property "disabled"
will always return true.

Proper implementation should be as below:
onget="return this.getAttribute('disabled') == 'true';"



Reproducible: Always

Steps to Reproduce:
1.xul: <menulist id="test" disabled="false"/>
2.js: var list = document.getElementById("test"); alert(list.disabled)
3.

Actual Results:  
returns true

Expected Results:  
should return false

Comment 1

[:Gavin Sharp [email: [e-mail]]]

This has been fixed on the trunk by bug 286079. Fix will be in Firefox 1.5.