303432 - nsPrintSettings::GetPrinterName lacks an OOM check

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Bastiaan Jacques]

nsPrintSettings::GetPrinterName should return OOM (and not NS_OK) when
allocation fails.

Comment 1

[Bastiaan Jacques]

Attachment: fix

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 191604 [details] [diff] [review]
fix

r+sr=dmose

Comment 3

[Bastiaan Jacques]

Checked in on (1.9) trunk by timeless (2005-08-12 16:11). Leaving this open,
because I don't know whether or not drivers want this for 1.8b4.

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 191604 [details] [diff] [review]
fix

this isn't really a blocker and we really don't care about taking these kinds
of fixes so late in the game. Soon we'll start saying no.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

MOZILLA_1_8_BRANCH:
Checking in gfx/src/nsPrintSettingsImpl.cpp;
/cvsroot/mozilla/gfx/src/nsPrintSettingsImpl.cpp,v  <-- 
nsPrintSettingsImpl.cppnew revision: 1.24.20.1; previous revision: 1.24
done

Comment 6

[Bastiaan Jacques]

Thanks biesi!