Closed
Bug 303432
Opened 20 years ago
Closed 20 years ago
nsPrintSettings::GetPrinterName lacks an OOM check
Categories
(Core :: Printing: Output, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bastiaan, Assigned: bastiaan)
Details
(Keywords: fixed1.8)
Attachments
(1 file)
|
996 bytes,
patch
|
dmosedale
:
review+
dmosedale
:
superreview+
asa
:
approval1.8b4+
|
Details | Diff | Splinter Review |
nsPrintSettings::GetPrinterName should return OOM (and not NS_OK) when
allocation fails.
|
Assignee | |
Comment 1•20 years ago
|
||
|
|
Assignee | |
Updated•20 years ago
|
Attachment #191604 -
Flags: superreview?(dmose)
Attachment #191604 -
Flags: review?(dmose)
|
||
Comment 2•20 years ago
|
||
Comment on attachment 191604 [details] [diff] [review]
fix
r+sr=dmose
Attachment #191604 -
Flags: superreview?(dmose)
Attachment #191604 -
Flags: superreview+
Attachment #191604 -
Flags: review?(dmose)
Attachment #191604 -
Flags: review+
|
|
Assignee | |
Updated•20 years ago
|
Attachment #191604 -
Flags: approval1.8b4?
|
|
Assignee | |
Comment 3•20 years ago
|
||
Checked in on (1.9) trunk by timeless (2005-08-12 16:11). Leaving this open,
because I don't know whether or not drivers want this for 1.8b4.
|
||
Comment 4•20 years ago
|
||
Comment on attachment 191604 [details] [diff] [review]
fix
this isn't really a blocker and we really don't care about taking these kinds
of fixes so late in the game. Soon we'll start saying no.
Attachment #191604 -
Flags: approval1.8b4? → approval1.8b4+
|
||
Comment 5•20 years ago
|
||
MOZILLA_1_8_BRANCH:
Checking in gfx/src/nsPrintSettingsImpl.cpp;
/cvsroot/mozilla/gfx/src/nsPrintSettingsImpl.cpp,v <--
nsPrintSettingsImpl.cppnew revision: 1.24.20.1; previous revision: 1.24
done
Keywords: fixed1.8
|
|
Assignee | |
Comment 6•20 years ago
|
||
Thanks biesi!
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•