303502 - make DOM "Don't call me!" asserts more meaningful.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Bob Clary [:bc] (inactive)]

When tracking assertions, simple asserts with "Don't call me!" don't really help
in easily determining the location of the problem. While asserts do show the
file/line number, these can change over time making automatic historical
comparisons difficult.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: patch

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 191660 [details] [diff] [review]
patch

>Index: content/html/document/src/nsHTMLDocument.cpp
>===================================================================

> nsresult
> nsHTMLDocument::UpdateNameTableEntry(const nsAString& aName,
>                                      nsIContent *aContent)
> {
>-  NS_ASSERTION(!IsXHTML(), "Don't call me on an XHTML document!!!");
>+  NS_ASSERTION(!IsXHTML(), 
>+  "nsHTMLDocument::UpdateNameTableEntry Don't call me on an XHTML document!!!");

I'd really prefer if these were all like this:

"Don't call nsHTMLDocument::UpdateNameTableEntry on an XHTML document!!!"

instead of just prefixing them.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 191660 [details] [diff] [review]
patch

sr=jst

Comment 4

[Bob Clary [:bc] (inactive)]

jst, I don't seem to have permission to check this in, can you take it for me?
The patch still applies cleanly with some offsets.

Comment 5

[Bob Clary [:bc] (inactive)]

I found my cvs horkage. Will check this into trunk later today.

Comment 6

[Bob Clary [:bc] (inactive)]

Checking in content/html/document/src/nsHTMLDocument.cpp;
/cvsroot/mozilla/content/html/document/src/nsHTMLDocument.cpp,v  <-- 
nsHTMLDocument.cpp
new revision: 3.625; previous revision: 3.624
done
Checking in dom/src/base/nsDOMClassInfo.cpp;
/cvsroot/mozilla/dom/src/base/nsDOMClassInfo.cpp,v  <--  nsDOMClassInfo.cpp
new revision: 1.308; previous revision: 1.307