303995 - Opening dependent window now creates item in windows task bar

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[Martijn Wargers (dead)]

See upcoming testcase.
A dependent window should not create an extra item in the task bar in windows,
and that is what is happening in current trunk builds.
This regressed between 2005-07-18 and 2005-07-19. "patch v.4" from bug 297683 is
the likely culprit.
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/widget/src/windows&command=DIFF_FRAMESET&file=nsWindow.cpp&rev1=3.563&rev2=3.564&root=/cvsroot

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

Comment 2

[Doug Turner (:dougt)]

will take a look tomorrow.

Comment 3

[Doug Turner (:dougt)]

fyi, I recently (as in a few minutes ago) checked in code that touches this same
area:

http://tinderbox.mozilla.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/widget/src/windows&command=DIFF_FRAMESET&file=nsWindow.cpp&rev1=3.565&rev2=3.566&root=/cvsroot

Comment 4

[Doug Turner (:dougt)]

Attachment: patch v.1

I see the problem.  Comparing the flags used in version 3.538 of nsWindow.cpp
and what we are currently using you see a difference in both the popup and
toplevel.  This patch reverts my changes and takes us back to a good place.

I have not tested this patch, but will when my builds complete.

Dan, this is a pretty straight forward backout of a windows bustage i caused. 
it really is a fine example of why #ifdefs suck.  Assuming that the testing
goes well, i will need a r/sr/a.

Comment 5

[Benjamin Smedberg]

Comment on attachment 192070 [details] [diff] [review]
patch v.1

Yes, this reverts to the original flags ;-)

Comment 6

[Doug Turner (:dougt)]

Checking in nsWindow.cpp;
/cvsroot/mozilla/widget/src/windows/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 3.567; previous revision: 3.566
done

Martijn, thank you so much for finding this bug.

Comment 7

[Martijn Wargers (dead)]

Verified. Thank you for fixing!