304078 - Resize and keyboard events not firing in imageDocument with 'resize large images' enabled.

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Joshua Welderson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050809 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050809 Firefox/1.0+

When "Resize large images to fit in browser window" is checked, when viewing an
image larger than one's browser window, the keyboard shortcuts for zooming in
and out (+, -) do not trigger a zoom.  Additionally, if the browser window is
resized while the image is zoomed out, the image does not resize to match the
window.

Reproducible: Always

Steps to Reproduce:
1. Go to Tools -> Options -> Advanced -> General, and check "Resize large images
to fit in browser window."  Alternatively, go to about:config and set
browser.enable_automatic_image_resizing equal to true.
2. Set your browser to a resolution less than that of 1024 x 768.
3. Go to http://weblogs.mozillazine.org/hyatt/images/clean/header_title_blue.jpg.
4. Try to zoom in by using +, then out by using -.
5. Resize the window to another size smaller than the current one.
Actual Results:  
4. The image did not change size.
5. The image did not resize.

Expected Results:  
4. The image should have zoomed in on +, zoomed back out on -.
5. The image should have resized to fit in the smaller window.

This is not a bfcache bug.  It's possible that it's fallout from the split
window landing; I'm not sure.  The click event does work, though.

Comment 1

[Martijn Wargers (dead)]

Regressed between 2005-07-30 and 2005-07-31, so indeed very likely fall-out from
bug 296639.

Comment 2

[Johnny Stenback (:jst)]

Attachment: Fix.

nsImageDocument::SetScriptGlobalObject() registers events on the global, and
right after the window calls that method, it "restores" the listener manager
from the old window (or null in cases where we don't want to preserve event
handlers between document transitions, which is most cases) and blows away the
one where the listeners we just registerd in. This simply reorders the code so
that we don't loose listeners.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 192513 [details] [diff] [review]
Fix.

r=me

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 192513 [details] [diff] [review]
Fix.

sr=me, if someone in the know on branching wants to approve, this could go in
before the branch is cut.  Not a big deal either way.

/be

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Fixed by the checkin for bug 303267.