304191 - nsIVersionComparator can return 0 when versions are different

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Dave Townsend [:mossop]]

In certain situations the version comparator returns that the versions are equal
when they actually aren't. The following are the current results:

compare("1.2","1.2.2") returns 0
compare("1.2","1.2.0.2") returns 0
compare("1.2","1.2.1.2") returns -1
compare("1.2","1.2.1") returns 0

I have what I think is a working patch to attach in a moment.

Comment 1

[Dave Townsend [:mossop]]

Attachment: Check all remaining version parts

OnlyZeros currently ignores the last version part since ParseVP returns false
when it parses the last version part. Changing from a while to a do - while
solves this.

Comment 2

[Benjamin Smedberg]

Comment on attachment 192248 [details] [diff] [review]
Check all remaining version parts

Wow, good catch. I will add this to the unit test as well.

Comment 3

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 192248 [details] [diff] [review]
Check all remaining version parts

sr=shaver

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 192248 [details] [diff] [review]
Check all remaining version parts

Could hopefully get this in before the branch. It's a quick fix and I can't see
any way it could break anything.

Comment 5

[Dave Townsend [:mossop]]

Should have assigned to myself, apologies for the spam

Comment 6

[Benjamin Smedberg]

Fixed on trunk for 1.8b4, with extra comparisons in the unit test.

Comment 7

[Benjamin Smedberg]

Comment on attachment 192248 [details] [diff] [review]
Check all remaining version parts

oh yeah, a=me