Closed Bug 304377 Opened 20 years ago Closed 20 years ago

create a client.mk project to use for tagging and branching

Categories

(Firefox Build System :: General, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: chase, Assigned: chase)

Details

(Keywords: fixed1.8)

Attachments

(3 files, 3 obsolete files)

At the top level of http://lxr.mozilla.org/mozilla/source/client.mk#92, there's a set of projects that can be used to pull files. In tagging previous releases and in branching for 1.8, the need arises for each one to have an easy way to pull all the files that should be tagged for that release. I'll provide a patch to client.mk that adds an 'all' project which also pulls the extra files listed on release-checklist.html. Looking for input on this, especially from bsmedberg.
Status: NEW → ASSIGNED
Attachment #192459 - Flags: superreview?(benjamin)
Attachment #192459 - Flags: review?(bryner)
Attachment #192459 - Flags: superreview?(benjamin)
Attachment #192459 - Flags: review?(bryner)
Attachment #192459 - Attachment is obsolete: true
Attachment #192461 - Flags: superreview?(benjamin)
Attachment #192461 - Flags: review?(bryner)
Comment on attachment 192461 [details] [diff] [review] Add 'all' project to client.mk, v. 1.1 Use MOZ_PROJECT_LIST like I meant to.
Gah.
Attachment #192461 - Attachment is obsolete: true
Attachment #192461 - Flags: superreview?(benjamin)
Attachment #192461 - Flags: review?(bryner)
Attachment #192462 - Flags: superreview?(benjamin)
Attachment #192462 - Flags: review?(bryner)
Attachment #192462 - Flags: approval1.8b4?
This version removes the need for the misc module and fixes a bug that would cause those extra files to fail to be added to MOZ_MODULE_LIST.
Attachment #192462 - Attachment is obsolete: true
Attachment #192462 - Flags: superreview?(benjamin)
Attachment #192462 - Flags: review?(bryner)
Attachment #192462 - Flags: approval1.8b4?
Attachment #192471 - Flags: review+
Comment on attachment 192471 [details] [diff] [review] Add 'all' project to client.mk, v. 2 Need to land this to help me branch tomorrow. bsmedberg, feel free to take a look when you get a free moment.
Attachment #192471 - Flags: superreview+
Attachment #192471 - Flags: review+
Attachment #192471 - Flags: approval1.8b4+
Comment on attachment 192471 [details] [diff] [review] Add 'all' project to client.mk, v. 2 Thanks bryner!
Attachment #192471 - Flags: review+
Comment on attachment 192471 [details] [diff] [review] Add 'all' project to client.mk, v. 2 Landed this on the trunk. Checking in client.mk; /cvsroot/mozilla/client.mk,v <-- client.mk new revision: 1.244; previous revision: 1.243 done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment on attachment 192471 [details] [diff] [review] Add 'all' project to client.mk, v. 2 Do you want to include mozilla/other-licenses/bsdiff in this list? Just as a style note, we really shouldn't have the trailing slash on the directory names.
Attachment #192514 - Flags: review?(benjamin)
Attachment #192514 - Flags: review?(benjamin) → review+
Comment on attachment 192514 [details] [diff] [review] Add bsdiff and remove trailing slashes, v. 1 Landing this to help me branch.
Attachment #192514 - Flags: approval1.8b4+
Comment on attachment 192514 [details] [diff] [review] Add bsdiff and remove trailing slashes, v. 1 Checking in client.mk; /cvsroot/mozilla/client.mk,v <-- client.mk new revision: 1.245; previous revision: 1.244 done
The tinderboxes were pulling this as well.
Attachment #192569 - Flags: review?(benjamin)
Attachment #192569 - Flags: approval1.8b4?
Attachment #192569 - Flags: review?(benjamin)
Attachment #192569 - Flags: review+
Attachment #192569 - Flags: approval1.8b4?
Attachment #192569 - Flags: approval1.8b4+
Comment on attachment 192569 [details] [diff] [review] add tools/update-packaging Checked into trunk, 2005-08-12 19:49 -0700. Checked in to MOZILLA_1_8_BRANCH, 2005-08-13 12:32 -0700.
Keywords: fixed1.8
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: