304582 - Move GenerateRandomPassword out of globals.pl

Status: RESOLVED FIXED

(Bugzilla :: User Accounts, enhancement)

Description

[Frédéric Buclin]

It should go into Token.pm as generate_random_token() as 'token' is more
appropriate than 'password'. Actually used in two places only:

Token.pm, line 170: $token = &::GenerateRandomPassword();
User.pm, line 1184: $password ||= &::GenerateRandomPassword();

Comment 1

[Frédéric Buclin]

It appears that moving this function into Token.pm doesn't work due to a module
dependency loop:

User -> Token -> BugMail -> User

It looks like the only other reasonable place is Util.pm, even if it's really
not my favorite choice.

Comment 2

[Frédéric Buclin]

Attachment: patch, v1

Comment 3

[Frédéric Buclin]

Comment on attachment 194156 [details] [diff] [review]
patch, v1

Marc seems away these days; asking joel.

Comment 4

[Frédéric Buclin]

Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.337; previous revision: 1.336
done
Checking in Bugzilla/Token.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Token.pm,v  <--  Token.pm
new revision: 1.36; previous revision: 1.35
done
Checking in Bugzilla/User.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v  <--  User.pm
new revision: 1.77; previous revision: 1.76
done
Checking in Bugzilla/Util.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Util.pm,v  <--  Util.pm
new revision: 1.40; previous revision: 1.39
done