305017 - Memory Leak: myspell object gets leaked

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Scott MacGregor]

in mozMySpell.cpp, SetDictionary creates an instance of class myspell. This
object is never deleted in the destructor for mozMySpell.

allocator:
http://lxr.mozilla.org/mozilla/source/extensions/spellcheck/myspell/src/mozMySpell.cpp#137

failure to delete in the destructor:
http://lxr.mozilla.org/mozilla/source/extensions/spellcheck/myspell/src/mozMySpell.cpp#83

Comment 1

[Scott MacGregor]

Attachment: the fix

1) delete the myspell instance in our destructor
2) Make SetDictionary smart enough (without leaking) to be called more than
once (i.e. delete the previous value for mMySpell if there is one. 
3) Clean up the destructor for the myspell class to avoid some unnecessary if
checks and setting values to NULL after deleting them in the dtor.

Comment 2

[Scott MacGregor]

I'll need this leak fix in 1.8b4 as part of the work I'm doing for another bug. 

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 192990 [details] [diff] [review]
the fix

r=mvl

Comment 4

[Scott MacGregor]

fixed on the trunk

Comment 5

[Scott MacGregor]

fixed branch and trunk