305158 - Checkin for bug 304739 broke contentAreaClick()

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Boris Zbarsky [:bzbarsky]]

STEPS TO REPRODUCE:  Try to middle-mouse-paste a URL into the content area. 
Watch nothing happen other than an error that the empty string url was blocked
by security in the JS console.

The problem is that the patch for bug 304739 changed contentAreaClick() as follows:

-    var ceParams = {event: event, href: "", linkNode: null};
-    hrefAndLinkNodeForClickEvent(ceParams);
-    var href = ceParams.href;
-    if (href) {
+    var ceParams = hrefAndLinkNodeForClickEvent(event);
+    if (ceParams) {

The problem is that |ceParams| is NEVER null here, because the code at
http://lxr.mozilla.org/seamonkey/source/xpfe/communicator/resources/content/contentAreaClick.js#152
guarantees that linkNode is never null at the end of
hrefAndLinkNodeForClickEvent().  So we end up taking the "link" click path even
if no link was actually clicked instead of doing what we're supposed to be doing...

Comment 1

[Boris Zbarsky [:bzbarsky]]

In fact, I suspect all other callers of hrefAndLinkNodeForClickEvent() got
broken too, reading over the patch in bug 304739.

Comment 2

[Ian Neal]

Attachment: Bustage fix v0.1 (Checked in)

This patch:
* Checks for href as was originally done after calls to
hrefAndLinkNodeForClickEvent instead of linkNode.

Comment 3

[Ian Neal]

Comment on attachment 193115 [details] [diff] [review]
Bustage fix v0.1 (Checked in)

Checking in
contentAreaClick.js;
new revision: 1.52; previous revision: 1.51
done