305271 - [FIX] Bogus assert in nsFrameManager::GenerateStateKey

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

Bob ran into this:

ASSERTION: nsFrameManager::GenerateStateKey didn't find form control index!:
'index > -1', file nsContentUtils.cpp, line 1487

at http://developer.ebay.com/DevProgram/?ssPageName=home:f:f:US

The problem is that this will file any time we're restoring state for an
nsIFormControl which is not in form.elements.  Minimal testcase is in the URL field.

Given that this is a perfectly normal situation, I think we should just remove
this assert.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 193229 [details] [diff] [review]
Proposed patch

So should we be using the index of the control in the document in that case?
(cf
http://lxr.mozilla.org/seamonkey/source/content/base/src/nsContentUtils.cpp#151
8)

Comment 3

[Boris Zbarsky [:bzbarsky]]

This is a pretty rare case, so I think it's OK to fall back on the content ID here.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 193229 [details] [diff] [review]
Proposed patch

Requesting 1.8b4 approval -- very safe patch that removes a bogus assertion.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Fixed on branch.