305281 - OS/2: Firefox fails to start

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Rich Walsh]

On OS/2, Firefox terminates because profiles.ini is being handled as text rather
than binary.  When read, the number of bytes returned doesn't equal the file's
size because the line terminators have been changed.

xpcom/glue/nsINIParser.cpp contains a #define for XP_WIN to deal with this.  The
attached patch extends the #define to include XP_OS2 as well.
a setanimret xoferiF
FL ot FLRC morf degnahc gnidaer si

Comment 1

[Rich Walsh]

Attachment: patch to nsINIParser.cpp

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 193239 [details] [diff] [review]
patch to nsINIParser.cpp

looks good.  if it works, lets get it into the trunk asap!

Comment 3

[Mike Kaply [:mkaply]]

Fix checked in.

Comment 4

[Rich Walsh]

57 seconds to get a patch reviewed & another 9 minutes, 9 seconds to get it
checked in - that's pretty good :-)

> a setanimret xoferiF
> FL ot FLRC morf degnahc gnidaer si

Now, if only we knew what's wrong with html text areas in today's build...

Comment 5

[Doug Turner (:dougt)]

i was wondering if you were banging your head on the keyboard.. :-)

Comment 6

[Rich Walsh]

> a setanimret xoferiF
> FL ot FLRC morf degnahc gnidaer si

These are actually snippets of stuff I edited out - but in reverse!  It reads
"Firefox terminates a"
"is reading changed from CRLF to LF"

Comment 7

[Felix Miata]

"a setanimret xoferiF" looks like bug 305239

Comment 8

[Steve England [:stevee]]

Can this bug now be RESOLVED FIXED?

Comment 9

[Peter Weilbacher]

Comment on attachment 193239 [details] [diff] [review]
patch to nsINIParser.cpp

This is needed on the 1.8 branch as well, a Firefox without it has the same
problems as on trunk.

Comment 10

[Mike Kaply [:mkaply]]

Comment on attachment 193239 [details] [diff] [review]
patch to nsINIParser.cpp

a=mkaply