Closed
      
        Bug 305483
      
      
        Opened 20 years ago
          Closed 20 years ago
      
        
    
  
--enable-canvas cannot be used with --enable-system-cairo
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
        RESOLVED
        FIXED
        
    
  
People
(Reporter: wolfiR, Assigned: glandium)
Details
(Keywords: fixed1.8)
Attachments
(1 file)
| 
        
        
         469 bytes,
          patch         
       | 
      
           roc
 :
              
              review+
          roc
 :
              
              superreview+
          asa
 :
              
              approval1.8b4+
           | 
      Details | Diff | Splinter Review | 
while compilation of nsCanvasRenderingContext2D.o the include file cairo.h is
not found if --enable-system-cairo is used:
nsCanvasRenderingContext2D.cpp:79:19: error: cairo.h: No such file or directory
MOZ_CAIRO_CFLAGS and MOZ_CAIRO_LIBS are missing from the compiler call.
| Assignee | ||
          Comment 1•20 years ago
           
         | 
      ||
Here is a patch that just work for that issue. I don't know who to ask a review
for, though.
        Attachment #193479 -
        Flags: superreview+
        Attachment #193479 -
        Flags: review+
I'll check this in on trunk. Do we want it on branch?
checked in on trunk.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
| Reporter | ||
          Comment 4•20 years ago
           
         | 
      ||
Comment on attachment 193479 [details] [diff] [review]
Fix for this bug
I would love to have this on branch. One patch less to deliver.
        Attachment #193479 -
        Flags: approval1.8b4?
          Updated•20 years ago
           
         | 
      
        Attachment #193479 -
        Flags: approval1.8b4? → approval1.8b4+
          Updated•20 years ago
           
         | 
      
Flags: blocking1.8b4+
| Reporter | ||
          Comment 5•20 years ago
           
         | 
      ||
Checking in content/canvas/src/Makefile.in;
/cvsroot/mozilla/content/canvas/src/Makefile.in,v  <--  Makefile.in
new revision: 1.4.6.1; previous revision: 1.4
done
Keywords: fixed1.8
          Updated•14 years ago
           
         | 
      
Assignee: nobody → mh+mozilla
          Updated•7 years ago
           
         | 
      
Product: Core → Firefox Build System
          You need to log in
          before you can comment on or make changes to this bug.
        
Description
•