305624 - [FIX][@ nsContentUtils::Shutdown]

Status: RESOLVED FIXED

(Core :: Layout, defect, P1)

Description

[timeless]

Incident ID: 8605646
Stack Signature	nsContentUtils::Shutdown 74f68e24
Product ID	MozillaTrunk
Build ID	2005082205
Trigger Time	2005-08-22 08:19:40.0
Platform	Win32
Operating System	Windows NT 5.1 build 2600
Module	gklayout.dll + (000e0598)
URL visited	
User Comments	
Since Last Crash	0 sec
Total Uptime	1 sec
Trigger Reason	Access violation
Source File, Line No.
c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/content/base/src/nsContentUtils.cpp,
line 449
Stack Trace 	
nsContentUtils::Shutdown 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/content/base/src/nsContentUtils.cpp,
line 449]
nsGenericModule::Initialize 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/build/nsGenericFactory.cpp,
line 273]
nsGenericModule::GetClassObject 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/build/nsGenericFactory.cpp,
line 361]
nsNativeComponentLoader::GetFactoryFromModule 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/components/nsNativeComponentLoader.cpp,
line 1058]
nsNativeComponentLoader::GetFactory 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/components/nsNativeComponentLoader.cpp,
line 160]
nsFactoryEntry::GetFactory 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/components/nsComponentManager.h,
line 302]
nsComponentManagerImpl::CreateInstance 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/components/nsComponentManager.cpp,
line 1897]
CallCreateInstance 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/build/nsComponentManagerUtils.cpp,
line 158]
nsTypeAheadFind::Init 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/extensions/typeaheadfind/src/nsTypeAheadFind.cpp,
line 190]
nsTypeAheadFind::GetInstance 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/extensions/typeaheadfind/src/nsTypeAheadFind.cpp,
line 230]
nsComponentManagerImpl::GetServiceByContractID 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/components/nsComponentManager.cpp,
line 2410]
CallGetService 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/build/nsComponentManagerUtils.cpp,
line 95]
nsAppStartupNotifier::Observe 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/embedding/components/appstartup/src/nsAppStartupNotifier.cpp,
line 99]
main1 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpfe/bootstrap/nsAppRunner.cpp,
line 1059]
main 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpfe/bootstrap/nsAppRunner.cpp,
line 1738]
WinMain 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpfe/bootstrap/nsAppRunner.cpp,
line 1762]
kernel32.dll + 0x16d4f (0x7c816d4f)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Same as diff -w

Comment 3

[Boris Zbarsky [:bzbarsky]]

As timeless pointer out, we should null the pointer out after the delete there.

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 193577 [details] [diff] [review]
Same as diff -w

r+sr=jst

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 193577 [details] [diff] [review]
Same as diff -w

requesting branch approval; just a null-check that can prevent crashes.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Fixed on trunk.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Fixed on branch.