305663 - Command list includes eval twice

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Sacha Moufarrege]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20050123
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20050123

The "eval" command is listed twice in the list of commands the chatzilla client
displays.

"enable-plugin, eval, eval, exit, exit-mozilla, "

Reproducible: Always

Steps to Reproduce:
1. Run chatzilla
2. Look at the commands list under the 'client' tab


Actual Results:  
duplicate of the 'eval' command listed

Expected Results:  
one listing per command

Comment 1

[Frank Wein [:mcsmurf]]

This bug still exists with current trunk.

Comment 2

[Frank Wein [:mcsmurf]]

The problem are the lines under
http://lxr.mozilla.org/mozilla/source/extensions/irc/js/lib/command-manager.js#460
I guess this changed somewhere between Mozilla 1.5b and now, but i don't know when.

Comment 3

[James Ross]

We need to work out when and why 'eval' was not included naturally. One possible solution is to just add it, if the command exists, iff the list does not already include it.

Also, this is anything but a typo!

Comment 4

[Robert Ginda]

it may have something to do with the fact that *every* object has an eval method...


[EVAL-IN] "eval" in {}
[EVAL-OUT] true

Comment 5

[James Ross]

From my testing suite, it seems that Mozilla 1.0 has the problem noted in the
Command Manager comment, and 1.4 and 1.7 don't. I have a fix, patch in a sec.

Comment 6

[James Ross]

Attachment: Only add 'eval' if not already listed

Comment 7

[James Ross]

Attachment: Don't re-generate keys list

Comment 8

[James Ross]

Checked in --> FIXED.