305767 - Allow a different marker character for preprocessing CSS files

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P2)

Description

[Benjamin Smedberg]

Since CSS files tend to contain '#' at the beginning of lines (for ID
selectors), the preprocessor doesn't work well on them. The patch will allow an
arbitrary character to be the preprocessor-marker-character, and will alter
make-jars so that '%' is the preprocessor character for CSS files.

Comment 1

[Benjamin Smedberg]

Attachment: Preprocess CSS with '%'

Comment 2

[Hixie (not reading bugmail)]

Comment on attachment 193706 [details] [diff] [review]
Preprocess CSS with '%'

r=hixie, on the preprocessor parts at least (the other parts seemed fine too).

Comment 3

[Benjamin Smedberg]

fixed on trunk

Comment 4

[AKIHIRO Misaki (a.k.a Kuden)]

Winstripe
chrome://browser/skin/preferences/preferences.css

Is this no problem?

Comment 5

[Mike Connor [:mconnor]]

Its not a problem because its wrapped in a comment, but if we want it
preprocessed we need to s/#/%/ as appropriate.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Attachment: 1.8 branch patch

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch comparison

I used this to verify that the patch was correct.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

find -name "*.css" | xargs egrep "^#( |if|endif)"
also doesn't find any files that need preprocessing (just commented out license headers in files that aren't preprocessed anyways).

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 210808 [details] [diff] [review]
1.8 branch patch

extensions/help/resources/content/platformClasses.css; new revision: 1.2.28.1;
themes/classic/global/win/menu.css; new revision: 1.56.8.2;
toolkit/components/help/content/platformClasses.css; new revision: 1.2.20.1;
layout/style/Makefile.in; new revision: 1.7.12.1;
layout/style/forms.css; new revision: 3.104.4.4;
config/make-jars.pl; new revision: 3.84.2.3;
config/preprocessor.pl; new revision: 3.30.4.1;
config/preprocessor.txt; new revision: 1.3.20.1;
toolkit/content/xul.css; new revision: 1.61.2.6;
toolkit/themes/qute/communicator/pref/pref.css; new revision: 1.2.26.3;
toolkit/themes/qute/help/help.css; new revision: 1.5.2.1;
toolkit/themes/qute/help/sidebar.css; new revision: 1.3.10.2;
toolkit/themes/winstripe/help/help.css; new revision: 1.12.2.1;
mail/components/migration/content/migration.css; new revision: 1.4.4.2;
browser/base/content/searchDialog.css; new revision: 1.2.2.4;
browser/themes/winstripe/browser/browser.css; new revision: 1.17.2.11;