305813 - Error pages not read by screen reader

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

The error pages used by Gecko are not getting the correct doc finished loading
events exposed through MSAA. Actually the events are being fired on the old
page, so the previous page is being read instead.

Comment 1

[Aaron Leventhal]

I have a patch forthcoming which uses DOMContentLoaded, which gets fired for XUL
error pages and also has the benefit of firing before images are loaded, which
is a great benefit to screen reader users.

Comment 2

[Chris Beard]

this is late to the party, but we'll take it subject to a low-risk patch.

Comment 3

[Aaron Leventhal]

Attachment: Changes listed in bug comment. Changes only in accessibility module. Thoroughly tested.

1) Use DOMContentLoaded to fire load event when a new page is ready,
2) Don't fire load done for failed load in OnStateChange, 
3) Cache busy state on nsDocAccessible (mIsContentLoaded), 
4) Fix a comment in AddEventListeners
5) Use better focus check to determine whether complete page load event should
be fired
6) Use cached mIsContentLoaded state to prevent double events from being fired

This patch fixes also some occasions where the screen reader would load the
page twice.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 193926 [details] [diff] [review]
Changes listed in bug comment. Changes only in accessibility module. Thoroughly tested.

+  NS_ASSERTION(treeItem, "No docshelltreeitem for doc aAccessible");


shouldn't that be "for doc aDocNode"?

Comment 5

[Aaron Leventhal]

I have a test build based on branch with this patch:
http://ftp.mozilla.org/pub/mozilla.org/mozilla/accessibility/firefox/firefox-8-26-2005-branch-1.5-a11y-win32.exe

The screen reader vendors have QA tested with this build and give it a thumbs up.

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 193926 [details] [diff] [review]
Changes listed in bug comment. Changes only in accessibility module. Thoroughly tested.

sr=jst

Comment 7

[Chris Beard]

Comment on attachment 193926 [details] [diff] [review]
Changes listed in bug comment. Changes only in accessibility module. Thoroughly tested.

-'d for approval1.8b4.	patch needs to get in and bake on the trunk for a
couple of days with verification that it works and doesn't cause additional
regressions before we'll consider for branch.

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 193926 [details] [diff] [review]
Changes listed in bug comment. Changes only in accessibility module. Thoroughly tested.

re-requesting approval. we need to get this verified on the trunk first though.

Comment 9

[Aaron Leventhal]

This change requires the checkin for bug 306750 to work without crashing on some
pages during Alt+Left.

Comment 10

[Aaron Leventhal]

I'm going to mark verified for the screen reader vendor who tested this both on
trunk and with the build I posted on ftp, and said it works great. The ftp build
was here:
http://ftp.mozilla.org/pub/mozilla.org/mozilla/accessibility/firefox/firefox-8-26-2005-branch-1.5-a11y-win32.exe

Comment 11

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381