Closed
Bug 305992
Opened 20 years ago
Closed 20 years ago
nsIVersionComparator is broken in some circumstances
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
VERIFIED
FIXED
mozilla1.8beta4
People
(Reporter: mossop, Assigned: mossop)
Details
(Keywords: regression, verified1.8)
Attachments
(1 file)
|
1.51 KB,
patch
|
benjamin
:
review+
shaver
:
superreview+
shaver
:
approval1.8b4+
|
Details | Diff | Splinter Review |
Seems since the last patch for bug 300731 the version comparator is broken.
compare("0.7","0.7.3") returns 1 (should be -1)
compare("0.7.2","0.7.3") returns -1
Also can we please clean up the confusing comment in nsIVersionComparator.idl
|
Assignee | |
Updated•20 years ago
|
Flags: blocking1.9a1?
Flags: blocking1.8b4?
|
|
Assignee | |
Comment 2•20 years ago
|
||
In the case of an empty string, numA of the version part was not being
initialised.
Also included the change to the comment in nsIVersionComparator.idl.
Attachment #193873 -
Flags: superreview?(shaver)
Attachment #193873 -
Flags: review?(benjamin)
|
||
Comment 3•20 years ago
|
||
My apologies. I wrote the previous patch, and I did test it, but I guess my
debug build zeroed out the struct for me. Anyway, for what it matters, this is
the correct fix. I'd give you the r and a if I could. Sorry for the trouble.
|
|
Assignee | |
Comment 4•20 years ago
|
||
Mistakenly assigned to the wrong person again, sorry.
Assignee: dougt → mossop
Status: ASSIGNED → NEW
|
|
Assignee | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
|
||
Updated•20 years ago
|
Attachment #193873 -
Flags: review?(benjamin) → review+
|
|
||
Updated•20 years ago
|
Flags: blocking1.9a1?
Flags: blocking1.8b4rc?
Flags: blocking1.8b4?
Flags: blocking1.8b4+
|
||
Comment 5•20 years ago
|
||
Comment on attachment 193873 [details] [diff] [review]
Initialises version part properly when the string is empty
sr+a=shaver
Attachment #193873 -
Flags: superreview?(shaver)
Attachment #193873 -
Flags: superreview+
Attachment #193873 -
Flags: approval1.8b4+
|
|
||
Comment 6•20 years ago
|
||
fixed, trunk and 1.8branch
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Flags: blocking1.8b4rc?
Keywords: fixed1.8
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8beta4
|
||
Updated•20 years ago
|
Status: RESOLVED → VERIFIED
Keywords: fixed1.8 → verified1.8
You need to log in
before you can comment on or make changes to this bug.
Description
•