306160 - nsIDOMXULMenuListElement::GetInputField does not work for editable <menulist>

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Mats Palmgren (inactive)]

Spawned off from bug 305840 comment 28.

STEPS TO REPRODUCE
1. Add the flollowing block of code at a suitable place, for exmple in
the XUL part of IsFocusable() in nsEventStateManager.cpp:

printf("XUL focusFrame=%p aContent=%p\n", focusFrame, aContent);
if (1) {
  printf(" ++++++++++++++++++++++++++++++++++++++++\n");
  nsIFrame* f = focusFrame->GetParent();
  nsIFrameDebug* fdbg;
  f->QueryInterface(NS_GET_IID(nsIFrameDebug), (void**) &fdbg);
  if (fdbg)
    fdbg->List(f->GetPresContext(), stdout, 0);
  printf(" ----------------------------------------\n");
}

if (1) {
    nsCOMPtr<nsIDOMXULMenuListElement> menulist = do_QueryInterface(aContent);
    if (menulist) {
      printf("aContent implements nsIDOMXULMenuListElement\n");
      nsCOMPtr<nsIDOMXULTextBoxElement> textbox;
      menulist->GetInputField(getter_AddRefs(textbox));
      nsCOMPtr<nsIContent> input = do_QueryInterface(textbox);
      printf("menulist->GetInputField() => textbox=%p textbox.content=%p\n",
             textbox.get(), input.get());
    }
}

You need to include these too:
#include <nsIDOMXULMenuListElement.h>
#include <nsIFrameDebug.h>

2. Compile and then run the attached testcase and type ALT+M.

ACTUAL RESULTS
See attached trace file.

EXPECTED RESULTS
A non-null textbox.

Comment 1

[Mats Palmgren (inactive)]

Attachment: Testcase

Comment 2

[Mats Palmgren (inactive)]

Attachment: Trace log

Comment 3

[[e-mail]]

Attachment: Proposed patch

Oddly enough, there are no consumers of this method to fix ;-)

Comment 4

[Mats Palmgren (inactive)]

Comment on attachment 194068 [details] [diff] [review]
Proposed patch

r=mats

Does nsIDOMXULTreeElement need the same fix?

Comment 5

[[e-mail]]

Fix checked in.

(In reply to comment #4)
>Does nsIDOMXULTreeElement need the same fix?
We'll find out if anyone ever implements it ...