Closed
Bug 306259
Opened 20 years ago
Closed 20 years ago
Nits in nsPrintOptionsImpl
Categories
(Core :: Printing: Output, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bastiaan, Assigned: bastiaan)
Details
Attachments
(1 file, 1 obsolete file)
|
6.60 KB,
patch
|
timeless
:
review+
dmosedale
:
superreview+
|
Details | Diff | Splinter Review |
* Prefer construction over assignment.
* Make mDefaultFont a concrete type rather than a pointer.
* Use more nice macros.
|
Assignee | |
Comment 1•20 years ago
|
||
Attachment #194113 -
Flags: superreview?(dmose)
Attachment #194113 -
Flags: review?(timeless)
Attachment #194113 -
Flags: review?(timeless) → review+
|
||
Comment 2•20 years ago
|
||
Comment on attachment 194113 [details] [diff] [review]
patch v1
sr=dmose
Attachment #194113 -
Flags: superreview?(dmose) → superreview+
|
|
Assignee | |
Comment 3•20 years ago
|
||
Comment on attachment 194113 [details] [diff] [review]
patch v1
- if (mIndex >= mCount) {
- return NS_ERROR_UNEXPECTED;
- }
+ NS_ENSURE_STATE(mIndex >= mCount);
Oops! This change is wrong..
|
|
Assignee | |
Comment 4•20 years ago
|
||
Let's try that again, shall we..
Attachment #194113 -
Attachment is obsolete: true
Attachment #194220 -
Flags: superreview?(dmose)
Attachment #194220 -
Flags: review?(timeless)
|
|
||
Comment 5•20 years ago
|
||
Comment on attachment 194220 [details] [diff] [review]
patch v2
sr=dmose
Attachment #194220 -
Flags: superreview?(dmose) → superreview+
Attachment #194220 -
Flags: review?(timeless) → review+
|
|
Assignee | |
Comment 6•20 years ago
|
||
Checked in by timeless (2005-09-02 02:04).
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•