Closed
Bug 306363
Opened 20 years ago
Closed 20 years ago
Clean up nsContentUtils service getters
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: peterv, Assigned: peterv)
References
Details
Attachments
(1 file, 2 obsolete files)
|
61.45 KB,
patch
|
peterv
:
review+
peterv
:
superreview+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•20 years ago
|
||
|
|
Assignee | |
Comment 2•20 years ago
|
||
|
|
Assignee | |
Updated•20 years ago
|
Attachment #194228 -
Flags: superreview?(bzbarsky)
Attachment #194228 -
Flags: review?(bzbarsky)
|
||
Comment 3•20 years ago
|
||
Comment on attachment 194228 [details] [diff] [review]
v1 (diff -w)
>Index: content/base/src/nsContentUtils.cpp
> rv = CallGetService(kJSStackContractID, &sThreadJSContextStack);
>+ NS_ENSURE_SUCCESS(rv, rv);
There are a few places in this file that null-check sThreadJSContextStack.
Want to remove those checks?
r+sr=bzbarsky with that.
|
|
Assignee | |
Comment 4•20 years ago
|
||
Removed sThreadJSContextStack null-checks. Marking bz's r/sr.
Attachment #194222 -
Attachment is obsolete: true
Attachment #194228 -
Attachment is obsolete: true
Attachment #195439 -
Flags: superreview+
Attachment #195439 -
Flags: review+
|
|
Assignee | |
Updated•20 years ago
|
Attachment #194228 -
Flags: superreview?(bzbarsky)
Attachment #194228 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•20 years ago
|
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha
Depends on: 308920
|
||
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•