307153 - since 20050817: After closing a modal-dialog, focus isn't restored to the right element

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Asaf Romano (gone)]

Regression: In the bookmarks manager, after closing a sub-(modal?)-dialog, focus
isn't restored to the right element,  the result is a unresponsive toolbar
button set.

STR:
 1. Open BM, choose an item in the right three.
 2. Click Properties.
 3. Click Ok.

  --> The toolbar buttons do nothing unless you refocus the right tree.

Comment 1

[Asaf Romano (gone)]

Actually, this is larger problem, try this in a browser window:
1. Focus the content area
2. Open the about dialog (Windows/Linux) or the Add Bookmark Dialog (mac).
3. Close it

--> The content area isn't focused (arrow keys, etc. don't work).

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Confirmed regression using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050904
Firefox/1.0+

Comment 3

[Scott MacGregor]

can you guys put together a regression window on this for us? 

Comment 4

[Asaf Romano (gone)]

WFM in:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050816
Firefox/1.0+

Broken in:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050817
Firefox/1.0+

Comment 5

[Mats Palmgren (inactive)]

Confirming this regression is from bug 258285, specifically it's from the
"Window Switch" focus suppressions that was removed. I have updated my patch
in bug 306076 to address this issue as well (i.e. bring them back, but add a
matching unsuppress).

Comment 6

[Aaron Leventhal]

I have a fix for this which is not risky. It leaves in the original code but
adds a couple of null window checks. The null windows were causing the focus
suppression to misfire. So it fixes this bug without regressing any of the
testcase from the fix for bug 258285.

Comment 7

[Aaron Leventhal]

Attachment: Reverse part of bug 258153, but add null checks so that it doesn't misfire when there is no window yet during tab switching

Comment 8

[Brian Ryner (not reading)]

Comment on attachment 195018 [details] [diff] [review]
Reverse part of bug 258153, but add null checks so that it doesn't misfire when there is no window yet during tab switching

Looks ok, but can you fix the spelling of "suppress" in the comment while
you're here?

Comment 9

[Mike Schroepfer]

Comment on attachment 195018 [details] [diff] [review]
Reverse part of bug 258153, but add null checks so that it doesn't misfire when there is no window yet during tab switching

a=schrep - per phone discussion fix is low-risk and critical - land on branch
and trunk

Comment 10

[Asaf Romano (gone)]

verified on:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050906
Firefox/1.4