307924 - Dragging icon from Location Bar works only at 2nd attempt

Status: VERIFIED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

Description

[Hermann Schwab]

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.9a1) Gecko/20050910 SeaMonkey/1.1a
First noticed in BuildID 2005090705, but maybe older.

Currently you've got to reload a page opened in a new tab to get the icon,
that's another bug already filed. When you see an icon you've got to drag it
twice to succeed.

Steps to repeat:
1. If this bug doesn't show the mozilla icon in the location bar, reload.
2. Try to drag the icon to a folder in the personal toolbar:
   - the cursor doesn't change to dragging mode, the folder in PT gets a focus
ring, but doesn't open.

3. Retry to drag the Icon to a folder in the PT.
   - leaving the P.T. the cursor changes to the dragging cursor, the folder in
P.T opens, you can drop.

4. after switching to another tab and back, you've got to start at step 2, not
step 3.

5. Clicking multiple times before dragging doesn't help, you've got to leave the
URL-Box area twice.

Comment 1

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050909
Firefox/1.6a1 ID:2005090921

I see the same. Related to Bug 307411?  Regressed at the same time.
	

Comment 2

[Phil Ringnalda (:philor)]

Maybe related to bug 307411 in the "another regression of bug 306262" sense, but
while the patch in bug 307256 fixes bug 307411 for me, it doesn't fix this. bz,
is this yours, or just coincidental timing?

Comment 3

[Ria Klaassen (not reading all bugmail)]

Dragging a favicon from the addressbar to the bookmarks toolbar works in
1.9a1_2005090513 but fails in 1.9a1_2005090522 :)

Comment 4

[Hermann Schwab]

Ria, thanks for the timeframe. I didn't find builds between Sep 4th and 7th.

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=SeaMonkeyAll&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-09-05+20%3A00&maxdate=2005-09-05+22%3A00&cvsroot=%2Fcvsroot

I assume this bug is fallout from 
Bug 241503 Crash in GKLAYOUT.DLL on attempt to drag'n'drop mail messages/addresses

The bug wasn't OS/2 only, and not mail only.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Yeah, this is my regression, I think.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Fixed by checkin for bug 307256.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using build 2005-09-12-04 on Windows XP SeaMonkey trunk.