308369 - Stop copying stat cache when cloning nsIFile instances

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Darin Fisher]

Stop copying stat cache when cloning nsIFile instances

I now believe that this patch was a mistake.  See discussion in bug 307815 and
bug 307429.  Caching stat buffers is a real big hack that results in a variety
of workaround hacks.  The ability to dump the cache by cloning a nsIFile is
nice.  The alternative is to create a new nsIFile and initialize it via
initWithFile, but that is more work for consumers.  We should make nsIFile.clone
and nsILocalFile.initWithFile work consistently in this regard.

Comment 1

[Darin Fisher]

-> me

Comment 2

[Darin Fisher]

Attachment: v1 patch

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 195930 [details] [diff] [review]
v1 patch

do you really neet to zero the mFileInfo64?  I know it is being done in other
places.

Comment 4

[Josh Aas]

Comment on attachment 195930 [details] [diff] [review]
v1 patch

Why the memset calls? Also, are we just letting the perf win from 122892 go
away?

Comment 5

[Josh Aas]

I think I accidently killed dougt's sr+ since both of us were editing the
attachment at the same time and he hit submit first. I'd add my r+, but I don't
see why we need the memset calls that zero mFileInfo64.

Comment 6

[Darin Fisher]

I added the memset calls for consistency with the default constructors.  If we
want to drop memset from the copy constructors then we should do so for the
default constructors as well.  I suspect that there is no reason for the memset
calls, otherwise.

As for the performance impact of this change, I don't think it's significant
enough to concern us with the impending release.

Comment 7

[Darin Fisher]

Attachment: v1.1 patch

bye bye memset

Comment 8

[Darin Fisher]

fixed-on-trunk

Comment 9

[Scott MacGregor]

Darin, can you elaborate more for the triage team about why we should take this
fix for Firefox 1.5? What's the user impact, it's unclear from the bug? Thanks.

Comment 10

[Darin Fisher]

(In reply to comment #9)
> Darin, can you elaborate more for the triage team about why we should take this
> fix for Firefox 1.5? What's the user impact, it's unclear from the bug? Thanks.

Scott: This patch is needed in order to fix bug 307429 "properly."

Comment 11

[Scott MacGregor]

Thanks Darin. That bug has been marked as a 1.8b5 blocker so this bug must be too.

Comment 12

[Darin Fisher]

fixed1.8