Closed
Bug 315570
Opened 19 years ago
Closed 19 years ago
Add a reusable autocomplete result type that doesn't depend on Mork
Categories
(Toolkit :: Autocomplete, enhancement)
Tracking
()
RESOLVED
FIXED
People
(Reporter: brettw, Assigned: brettw)
References
Details
(Keywords: fixed1.8.1)
Attachments
(2 files, 1 obsolete file)
36.92 KB,
patch
|
bryner
:
first-review+
annie.sullivan
:
second-review+
|
Details | Diff | Splinter Review |
1.66 KB,
patch
|
benjamin
:
first-review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20051025 Firefox/1.5 Build Identifier: Current auto complete is a bit messy and the basic implementation depends on Mork, and all that is really needed is a way to set and store (value,comment) pairs. An implementation should be provided that makes it easy for random implementors to use without reimplementing the nsIAutoCompleteResult interface or using Mork. Reproducible: Always Steps to Reproduce:
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•19 years ago
|
Assignee: nobody → brettw
Status: ASSIGNED → NEW
Assignee | ||
Comment 1•19 years ago
|
||
This patch also changes the experimental (defaulted off) places history system to use the simple autocomplete result for URL autocompletion.
Attachment #202279 -
Flags: second-review?
Attachment #202279 -
Flags: first-review?(annie.sullivan)
Assignee | ||
Updated•19 years ago
|
Attachment #202279 -
Flags: second-review? → second-review?(bryner)
Assignee | ||
Comment 2•19 years ago
|
||
Attachment #202279 -
Attachment is obsolete: true
Attachment #202283 -
Flags: second-review?(annie.sullivan)
Attachment #202283 -
Flags: first-review?(bryner)
Attachment #202279 -
Flags: second-review?(bryner)
Attachment #202279 -
Flags: first-review?(annie.sullivan)
Comment 3•19 years ago
|
||
Comment on attachment 202283 [details] [diff] [review] Same as the previous one, but with obsolete files removed >+nsAutoCompleteSimpleResult::nsAutoCompleteSimpleResult() >+{ >+} This should initialize mDefaultIndex and mSearchResult. >--- browser/components/places/src/nsNavHistory.cpp 8 Nov 2005 02:25:22 -0000 1.1 >+++ browser/components/places/src/nsNavHistory.cpp 8 Nov 2005 18:55:04 -0000 >@@ -1887,67 +1945,62 @@ nsNavHistory::StopSearch() >- NS_LITERAL_CSTRING("SELECT url,title FROM moz_history WHERE typed = 1 AND hidden <> 1 ORDER BY visit_count DESC LIMIT 1000"), >+ NS_LITERAL_CSTRING("SELECT url,title FROM moz_history WHERE typed = 1 AND hidden <> 1 ORDER BY visit_count DESC LIMIT 100"), This change seems unrelated... Looks ok otherwise.
Attachment #202283 -
Flags: first-review?(bryner) → first-review+
Comment 4•19 years ago
|
||
Comment on attachment 202283 [details] [diff] [review] Same as the previous one, but with obsolete files removed looks good.
Attachment #202283 -
Flags: second-review?(annie.sullivan) → second-review+
Assignee | ||
Updated•19 years ago
|
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment on attachment 202283 [details] [diff] [review] Same as the previous one, but with obsolete files removed >+ ~nsAutoCompleteSimpleResult() {}; Extra ";", fwiw. Also, since it's not virtual, shouldn't it be private rather than protected? >+ friend struct AutoCompleteIntermediateResultSet; Some compilers (MSVC, I think) warn about the struct vs. class difference here. Also, declaring something a friend that hasn't been declared has significant portability differences: on some compilers it counts as a declaration at namespace scope, but in the standard I believe it doesn't. For portability, it's probably better to declare |class AutoCompleteIntermediateResultSet;| outside the class definition before declaring it a friend inside the class definition.
Assignee | ||
Comment 6•19 years ago
|
||
Fix for dbaron's comments.
Attachment #202415 -
Flags: first-review?(darin)
Updated•19 years ago
|
Attachment #202415 -
Flags: first-review?(darin) → first-review+
Updated•18 years ago
|
Keywords: fixed1.8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•