31892 - A crash occurs with onfocus event assigned to a AREA element

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[Chris Petersen]

Build: Apprunner
Version: 2000031318
Platform: Win
Other Platforms: Works on Mac.Need to try on Linux.
Expected Results: A dialog should appears generated by the onFocus event.
What I Got: The application crashes.


Steps to reproduce: 

1) Open the following test case:

http://mozilla.org/quality/browser/standards/html/area_onfocus.html


2) Click on the red circle.


3) The application should crash.

Comment 1

[joki (gone)]

Okay, if we still want this for beta I have a fix.  Non-threatening null check.

Comment 2

[Jim Roskind]

Please include a patch in the bug.
If I understand your comment, you have a one line null check.
Thanks,
Jim

Comment 3

[joki (gone)]

Here is the patch.

Index: nsImageMap.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/html/base/src/nsImageMap.cpp,v
retrieving revision 3.38
diff -r3.38 nsImageMap.cpp
915c915
<         if (NS_FAILED(rv)) return PR_FALSE;
---
>         if (NS_FAILED(rv) || !baseUri) return PR_FALSE;

Comment 4

[leger]

Putting on PDT- radar.  Does this impact any top 100?

Comment 5

[Chris Petersen]

Jan,

This test case wasn't distilled from a site so I don't know. But since both AREA 
maps and JS alert dialogs are frequently used, this problem may occur on various 
site.

Comment 6

[Jan Carpenter]

adding beta2 keyword, and removing pdt status

Comment 7

[Paul MacQuiddy]

removing beta1 keyword so it doesn't show up on beta1 radar

Comment 8

[rickg]

Moving to m16 due to severity

Comment 9

[leger]

Putting on [beta2+] radar....check it in!!!:-)

Comment 10

[leger]

Updating [beta2+] in Status Summary to [nsbeta2+]

Comment 11

[joki (gone)]

patch checked in

Comment 12

[Chris Petersen]

With the May 15th build (2000051508), I can nolonger reproduce this crash under 
Win 98. Marking verified fixed.