32011 - Webclient not ready for UNO

Status: RESOLVED WONTFIX

(Core Graveyard :: Java APIs to WebShell, defect, P3)

Description

[edburns]

Webclient isn't ready for being integrated into StarOffice.

At first, I thought we'd have to do some complicated #ifdef thing where we 
would define alternate function declarations for all the JNI functions.  Now I 
see that we can just leave the JNI function declarations as they are and use 
function pointers to make it easier to call them from UNO.  The trick is to 
replace all callsites where a function is invoked from a JNIEnv pointer with 
function calls to functions in jni_util.h.  The implementations of these 
functions will use #ifdef logic to do the right thing whether in UNO or JNI 
contexts.

Patch forthcoming.

Comment 1

[edburns]

Of course, webclient.dll will always have to be compiled with jni headers, even 
when compiling with the UNO style ifdefs.  However, when compiling with the UNO 
style ifdefs, there will be no calls to any JNI functions.  Just the type 
information will be used.

Comment 2

[edburns]

Attachment: Fix for this bug.

Comment 3

[edburns]

Here's the CVS comment for the patch:

This set of changes replaces all occurrences of 

env->Func(args...)

with 

::util_Func(env, args...)

Except of course, for the implementations of the above mentioned
::util_Func() functions.

This is done to allow the JNI functions to be called from a non JNI
context, such as UNO.

Comment 4

[edburns]

Attachment: Second Part of the fix.

Comment 5

[edburns]

This change enables the current webclient API to be called from native
code.  

It adds makefile and conditional compilation logic.

If the user defines BAL_INTERFACE in their environment before building
webclient, -DBAL_INTERFACE is added to LCFLAGS.  This causes code in
jni_util_export.cpp to behave differently due to the conditional
compilation logic.

I've broken out the 8 functions that are necessary to call into the
Webclient JNI methods into jni_util_export.{h,cpp}.  

I've created a new pair of files, bal_util.{h,cpp} that contain function
declarations and definitions that are used when src_moz is built with
BAL_INTERFACE.  bal_util.obj is not built, nor added to webclient.dll if
building without BAL_INTERFACE.

See the page
http://www.mozilla.org/projects/blackwood/webclient/design/uno-transition.html
for a design document description of these changes.

Comment 6

[edburns]

Attachment: Tar of changes defined in previous patch attachment. Includes new files.

Comment 7

[Ashu Kulkarni]

Hi Ed, 
I've checked the new patch submitted 03/20/00. It looks good.

r=ashuk

_Ashu

Comment 8

[edburns]

Thanks Ashu.

Comment 9

[edburns]

More changes will need to be made to webclient as the UNO integration work 
progresses.  Reopening.

Comment 10

[geetha.vaidyanaathan]

Adding Status white board keyword to track all existing Webclient bugs

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Java APIs to WebShell isn't a thing anymore. Closing.