32067 - Close all windows: Mac menu items disappear, Mozilla un-quittable, sometimes crashes

Status: VERIFIED WORKSFORME

(SeaMonkey :: UI Design, defect, P3)

Description

[Matthew T (active 1999-2002)]

Build: 2000031509, MacOS 8.6

To reproduce:
* Start Mozilla.
* Close all open windows.
* Browse the menu bar.

What happens:
* All menu items, except for submenu titles, menu separators, and items in the
  Help menu, have been removed. It is impossible to quit Mozilla, because the
  Quit menu item has gone. Selecting `Release Notes' from the Help menu, doesn't
  do anything.

What should happen:
* The menus should still be there. Non-applicable items should be disabled.

Comment 1

[Adam]

This isn't happening on M15 2000031908. However, I experienced this on the 3/18
build - this problem comes and goes a lot (a build either keeps its menus or
doesnt - meaning that if you don't experience it on the build you're using, you
won't). As long as the beta doesn't do it...

Comment 2

[Matthew T (active 1999-2002)]

[e-mail], I jave just reproduced this bug in MacOS build 2000031908, the same 
build in which you couldn't reproduce it. Mysteriouser and mysteriouser.

Comment 3

[sairuh (rarely reading bugmail)]

i cannot seem to repro this --using 2000.03.20.06-nb1b (beta1 branch build,
*not* the trunk build). were you using branch or trunk bits?

Comment 4

[Matthew T (active 1999-2002)]

> were you using branch or trunk bits?

Trunk bits.

Comment 5

[sairuh (rarely reading bugmail)]

weird --i was looking at this with today's trunk bits on macOS 9.0 [commercial,
2000.03.24.10], and still wasn't able to reproduce it. even after closing all
windows, i still had access to File > Quit.

mpt, have you seen this w/today's trunk bits?

eli, have you seen this? (either w/mozilla, or on 8.6...)

Comment 6

[Matthew T (active 1999-2002)]

The menus work fine on 2000022308 trunk build, MacOS 8.6. I don't have a more 
recent build to check.

Comment 7

[Simon Fraser [no longer active]]

If a composer window is foremost when you quit, you have to select Quit a second 
time (after the window has gone away) to actually quit. This is bug 29733.

If you close all windows, I think you can't use command-Q to quit, but the menu 
works. Is that what this bug is about?

Comment 8

[Adam]

No - what mpt is referring to is the fact that, when no windows are open in 

Mozilla, ALL menu items disappear except for separators and 

sub-heirarchies. I have seen this off and on over the past few months in 

the Mac builds.

Comment 9

[Eli Goldberg]

Yes, I just saw it with this morning's build a few minutes ago.

Comment 10

[Simon Fraser [no longer active]]

Ah, ok, that one. This is a saari bug, then. If anyone can get steps to 
reproduce, we'd like those.

Comment 11

[sairuh (rarely reading bugmail)]

eli, if you can repro this, come and grab me so i can see this --i've yet to
encounter it... so does it occur erratically?

Comment 12

[saari (gone)]

I havn't seen this either!

Comment 13

[Eli Goldberg]

Unfortunately, I don't see this more than once a month, and am at a loss for 

suggested reproduction steps.



Chris, if you have any ideas of what could be causing this, I'd be happy to poke 

around and see if I can translate it into reproduction steps.

Comment 14

[Simon Fraser [no longer active]]

I can guess. Some series of steps, which may involve opening/closing multiple 
windows at once, using mail etc, causes a memory leak (guessing here) such that 
the menu bar is retained, but all the items in it have been disposed of. Note 
that menu *items* disappear, but separators stay. So I think this is some kind of 
menubar/menuitem refcouting bug.

Comment 15

[Simon Fraser [no longer active]]

Attachment: stack for a menu-related crash

Comment 16

[Simon Fraser [no longer active]]

I think this same problem can cause crashes in some situations. Look at this 
stack for an example:

http://bugzilla.mozilla.org/showattachment.cgi?attach_id=7196

and the attachment I just made

Comment 17

[Simon Fraser [no longer active]]

I have one reproducible case (I think!) where menu badness happens:
1. Run Mozilla, see browser window.
2. Go to prefs. Change nothing. Click OK to dismiss prefs.
3. Close browser window. Now click on the menu bar. You crash in widget code,
   in a callback from MenusLib. My guess is that a prefs callback is leaking
   something.

Comment 18

[sairuh (rarely reading bugmail)]

yes! that does it (confirmed using opt comm bits 2000.04.04.10). the stack i see
is the same as the attached one here.

Comment 19

[Peter Trudelle]

Mass-moving all M16 non-feature bugs to M17, which we still consider to be 
part of beta2

Comment 20

[leger]

Adding crash keyword.

Comment 21

[Gervase Markham [:gerv]]

sairuh, sfraser: This WORKSFORME. This bug is fairly old; has anyone seen this 
recently, or can we close it out?

Gerv

Comment 22

[Simon Fraser [no longer active]]

Both brade and I have still seen recently crashes in the MDEF code after closing 
windows. I still think there is a timing-related bug lurking in here. Let's keep 
it open for a while longer.

Comment 23

[leger]

Putting on nsbeta2 radar.

Comment 24

[Jay Patel [:jay]]

Putting on [nsbeta2+] radar for beta2 fix. 

Comment 25

[saari (gone)]

Must be timing related, the described steps don't repro for me.

Comment 26

[John Morrison]

(and one mid-air collision later)
I can't reproduce the crash, or the loss of menu items, that are noted in 
this bug (2000070608 mac os 9.0). Is anyone else able to reproduce this?
If not, this bug should move off the nsbeta2 train.

Comment 27

[Peter Trudelle]

Doesn't fit latest 'would ya pull it off the wire' criteria, marking nsbeta2-,
nominating for nsbeta3

Comment 28

[Peter Trudelle]

nsbeta3-, probably a dead issue.

Comment 29

[John Bafford]

I just experienced this problem with 2000082520 on Mac OS 9, and repeated it 

several times. The menus, except for the Apple and Help menus disappear (but the 

menubar isn't repainted, so they look like they're still there), and the About 

Mozilla item in the Apple Menu does nothing. It is possible to quit Mozilla with 

a simple AppleScript, though.

Comment 30

[Matthew T (active 1999-2002)]

John, that's bug 49576, which is different from this bug in that all the menus 
disappear (not just the menu items).

Comment 31

[sairuh (rarely reading bugmail)]

mpt, have you been able to repro this recently? i haven't (at least with
commercial branch bits), so am gonna mark this wfm. do reopen if you see it with
a recent build (either trunk or branch).

Comment 32

[Matthew T (active 1999-2002)]

Nup, haven't seen this in ages. Verifying.