32541 - "ASSERTION: Failed to update state" when scrolling

Status: VERIFIED FIXED

(Core :: XUL, defect, P1)

Description

[Akkana Peck]

In the 3/20 debug build, I see the following assertion whenever I scroll down
(by dragging the scrollbar) in the editor:

###!!! ASSERTION: Failed to update state: 'NS_SUCCEEDED(rv)', file /builds/fri/m

nsInterfaceState::UpdateParagraphState is failing to find anchorNodeBlockParent
in the !isBlock case.

Comment 1

[Akkana Peck]

Turns out this code is Charley's.

Comment 2

[Charles Manske]

Something is really messed up! The root of the problem is that clicking on 
the scrollbar is pulling focus away from the editor window or changing
our selection to something very bad.
The "anchorNode" of the selection when the assertion occurs is a "XULElement"!

Comment 3

[Akkana Peck]

Ah, then it's probably related to the bug saari is working on.

Comment 4

[Eric Vaughan]

Is this you saari?

Comment 5

[saari (gone)]

mjudge fixed scrollbars to not steal selection, but they may still be stealing 
focus, although I don't see that. Bryner is seeing things to support that with 
some of the nsEventStateManager variables, but I havn't looked into it deeply 
enough to verify yet.

I don't think the assertion in this bug has anything to do with me though.

Comment 6

[Simon Fraser [no longer active]]

The assertion is mine, but it's a side-effect of some problem with the 
scrollbars; see cmanske's comment above.

Comment 7

[saari (gone)]

Hyatt and myself found something that may explain this; scrollbars got rearranged 
to be generated via XBL. When that happened, the syle rules for user-focus: 
ignore got out of synch, so the scrollbar could grab focus depending on where you 
clicked on it. As soon as Hyatt gets landing clearance from the Gecko tower, I'll 
update this bug.

Comment 8

[Peter Trudelle]

Mass-moving most M15 bugs to M16

Comment 9

[saari (gone)]

The change is in, are we still seeing the assertion?

Comment 10

[saari (gone)]

I don't see the assertion in my current linux build with editor or any text
areas, so I'm going to mark it fixed. I'm pretty sure the style changes fixed this.

Comment 11

[sujay]

verified in 4/11 build.