32719 - menus missing entirely from View Source Window, keyboard shortcuts busted

Status: VERIFIED DUPLICATE of bug 26593

(SeaMonkey :: UI Design, defect, P2)

Description

[Sean Richardson]

2000-03-21-08-M15 on Windows NT

The menus for the View Source window are now missing entirely. It seems that
they have been removed in two stages in versions 1.15 and 1.16 of 
viewSource.xul.

There is a fair bit of evidence that menus are intended to appear. The cvs log
for ver 1.14 shows "Minor fix to make viewSource window use overlay for View 
menu" and for 1.4, "Phase 1 of menu landing."
Based on the fix for bug 13535, "Find in View Source does find in the view 
souce window", it seems that the ability to search in the source window is
intended. Bug 26593, "^C doesn't work on view source window." needs Edit>Copy 
as a workaround, if it is still a problem on any platform.

On the other hand, the entire Go, Bookmarks, and Tasks menus are not 
particularly useful in the context of viewing source, and a number of
items could be removed from the File, Edit, and View menus.

Bug 24256, "View>Page Source can be recursive, probably shouldn't be" and
bug 31520, "In view-source, go menu has separator" apply to menus in the 
View source window, and can be closed out if this report is resolved as
WONTFIX.

Comment 1

[sairuh (rarely reading bugmail)]

keyboard shortcuts (eg, Alt+W to close) don't work anymore, either.

should this be reassigned to bill?

Comment 2

[Bill Law]

By rights, this would go to Travis.  I believe he changed the viewsource xul 
scheme recently to utilize base docshell function rather than code in 
nsBrowserInstance (at least that was my take on it).

Anyway, some of the stuff needs to be redone.  Ben would probably be best at it.  
I'm willing to do it if that's the best allocation of resources.  Ben can 
reassign as he sees fit.

Comment 3

[Kathleen :Brade]

*** Bug 33676 has been marked as a duplicate of this bug. ***

Comment 4

[don]

M16.  Ben, re-assign as you see fit.

Comment 5

[jglick]

View source window shouldn't have menu items. Confirmed by German.

Comment 6

[sairuh (rarely reading bugmail)]

updated summary.

if it ends up that we don't put the menus back into View Source, okay --but
keyboard shortcuts should still be enabled (see bug 33676, which was made a dup
of this one).

Comment 7

[Kathleen :Brade]

people should cc themselves on the bug for keybindings in view source window (bug 
#26593) if so desired


*** This bug has been marked as a duplicate of 26593 ***

Comment 8

[sairuh (rarely reading bugmail)]

verif.

Comment 9

[Jesse Ruderman]

Looks like discussion is continuing in bug 63026.