337149 - Bookmarks menu -> Open in tabs , or middleclick on folder ,leaves bookmarks menu open

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Peter van der Woude [:Peter6]]

repro:
1.Open bookmarks menu
2.Either middleclick on a folder or choose "open in tabs in a folder"

result:
The bookmarks menu does not close

regressionwindow:
works in 20060322 1525pst build
fails in 20060323 0652pst build

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&filetype=match&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-03-22+14%3A45%3A00&maxdate=2006-03-23+06%3A52%3A00&cvsroot=%2Fcvsroot

Comment 1

[Ria Klaassen (not reading all bugmail)]

Bug 334214 ?

Comment 2

[Peter van der Woude [:Peter6]]

(In reply to comment #1)
> Bug 334214 ?
> 

I don't think so
Yours has a different regressionwindow (20060327 i/o 20060323)

Comment 3

[Ria Klaassen (not reading all bugmail)]

(In reply to comment #2)
>
Rechecked, and is regressionrange of Bug 334214 is correct.  

Comment 4

[Peter van der Woude [:Peter6]]

(In reply to comment #3)
> (In reply to comment #2)
> >
> Rechecked, and is regressionrange of Bug 334214 is correct.  
> 
rechecked too, this rage stands aswell

btw, this one is 100% reproducable

Comment 5

[tabmix.onemen]

in openLinksInTabs function...........

     // Close any remaining open tabs that are left over.
     // (Always skipped when we append tabs)
     for (var i = tabCount - 1; i >= index; --i)
       browser.removeTab(tabs[i]);

     // and focus the content
-    this.browserWindow.content.focus();
+    this._getBrowserWindow().content.focus();

Comment 6

[(mostly gone) XtC4UaLL [:xtc4uall]]

as of http://lxr.mozilla.org/seamonkey/source/browser/components/places/content/controller.js#936 it's stated now as "browserWindow.content.focus();" + mentioned issue is WFM now -> WORKSFORME ?

Comment 7

[Marco Bonardo [:mak]]

this WFM on
Build identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007082415 Minefield/3.0a8pre

Comment 8

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007082322 Minefield/3.0a8pre ID:2007082322

WFM

Comment 9

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv