33798 - Overlays can be loaded in an infinite recursion (or cycle)

Status: RESOLVED FIXED

(Core :: XUL, defect, P4)

Description

[John Morrison]

Overview Description:
   In the category of boring, defensive programming ...
   
   An overlay can load itself as an overlay. Perhaps more critically is that 
   an overlay 'A' may load an overlay 'B' which loads overlay 'A' ... which 
   may be a more possible use case as packages and package extensions are 
   developed.

   This is of course an error on the part of the package developer, but it is
   a error condition that could/should be trapped.

Steps to Reproduce:
1) Add the line 
       <?xul-overlay href="chrome://navigator/content/netscape.xul"?>
   to the top of chrome://navigator/content/netscape.xul, and then start 
   mozilla. [Setting up a cycle is, of course, just one additional step away].

Actual Results: 
  infinite loop 

Expected Results: 
  either:  
    a) abort the launch with an error message (if possible).
    b) ignore further overlays as soon as the cycle|recursion is detected.

Reproducibility: 
  always

Build Date & Platform Bug Found: 
  2000032709 win98 (although I didn't "find" this one.)

Additional Builds and Platforms Tested On:
  this is xp

Comment 1

[Peter Trudelle]

I think we could live with this for now, moving to siberia & cc'ing hyatt in
case he feels otherwise.

Comment 2

[Peter Trudelle]

Mass move of all M20 bugs to M30.

Comment 3

[Peter Trudelle]

Mass move of M20 bugs to M30

Comment 4

[Peter Trudelle]

Mass-moving all M20-M30 XPToolkit bugs to Future

Comment 5

[Peter Trudelle]

->hyatt/untargetted. We are getting requests from the Apps group to make their
lives easier in ways like this, when/where we can.

Comment 6

[Peter Trudelle]

this is fixed (by pollmann's fix)