338796 - Remove get_product_* from globals.pl

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Frédéric Buclin]

We should use Bugzilla::Product objects now.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

It's impressive the cleanup we can do in enter_bug.cgi when working with a product object only. :) Note that I didn't remove $vars->{'version'} and $vars->{'target_milestone'} because they would require some more work (which is not the topic of this bug). The reason I removed $vars->{'component_'} is because it was trivial to do. :)

Comment 2

[Teemu Mannermaa (:wicked)]

Comment on attachment 225747 [details] [diff] [review]
patch, v1

Cool, nice cleanup. I love objects. Just fix following non-nits before commit.

>Index: editflagtypes.cgi
>===================================================================
>+            $products{$product_id} ||= new Bugzilla::Product($product_id);
>+            $product_name = $products{$product_id}->name;

Nit: What if product doesn't exist anymore? Write
  $product_name = $products{$product_id}->name if $products{$product_id}; 
instead. Bonus points for fixing this in the next block doing same for component.

>-            next if ($component_id
>+                return unless scalar(@match);

Are you sure? :) I wouldn't be so s/return/next/

>Index: enter_bug.cgi
>===================================================================
>+$user->can_enter_product($product ? $product->name : undef, THROW_ERROR);

Not undef but rather $product_name so we get same error as before.

Comment 3

[Frédéric Buclin]

Attachment: patch, v1.1

comments fixed.

Comment 4

[Frédéric Buclin]

Checking in collectstats.pl;
/cvsroot/mozilla/webtools/bugzilla/collectstats.pl,v  <--  collectstats.pl
new revision: 1.50; previous revision: 1.49
done
Checking in duplicates.cgi;
/cvsroot/mozilla/webtools/bugzilla/duplicates.cgi,v  <--  duplicates.cgi
new revision: 1.53; previous revision: 1.52
done
Checking in editflagtypes.cgi;
/cvsroot/mozilla/webtools/bugzilla/editflagtypes.cgi,v  <--  editflagtypes.cgi
new revision: 1.37; previous revision: 1.36
done
Checking in editgroups.cgi;
/cvsroot/mozilla/webtools/bugzilla/editgroups.cgi,v  <--  editgroups.cgi
new revision: 1.71; previous revision: 1.70
done
Checking in enter_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/enter_bug.cgi,v  <--  enter_bug.cgi
new revision: 1.135; previous revision: 1.134
done
Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.370; previous revision: 1.369
done
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.324; previous revision: 1.323
done
Checking in Bugzilla/BugMail.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/BugMail.pm,v  <--  BugMail.pm
new revision: 1.78; previous revision: 1.77
done
Checking in template/en/default/bug/create/create-guided.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create-guided.html.tmpl,v  <--  create-guided.html.tmpl
new revision: 1.31; previous revision: 1.30
done
Checking in template/en/default/bug/create/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.59; previous revision: 1.58
done