34050 - Save PNG/GIF image from contextual menu crashes browser at download

Status: VERIFIED WORKSFORME

(SeaMonkey :: UI Design, defect, P2)

Description

[Barry King]

Save Image contextual menu on any png causes either browser crash (macintosh, web 
source) or hung browser (local source for macintosh or given source, i.e. PNG 
logo on www.lwn.net page with Win95)

Comment 1

[sairuh (rarely reading bugmail)]

tested with following optimized commercial bits:

linux, 2000.03.30.09
macOS, 2000.03.30.10
winNT, 2000.03.31.09

i didn't get a crash, but i did get as far as the XP Saving File dialog, which
just sat there...forever. just clicked Cancel to dismiss the dialog; the png
file never downloaded. (what i did is scrolled down to the bottom of the page,
and attempted to save the "Linux Powered" image in the lower right corner,
linuxpower2.png.)

updating component --although lemme know if it should go elsewhere.

eli, you deal with images --d'you think this an issue w/PNG or downloading? i
was able to download other files, eg, zip files...

Comment 2

[sairuh (rarely reading bugmail)]

bill, would this belong to you...?

Comment 3

[sairuh (rarely reading bugmail)]

hey, i was able to get the browser to crash when trying to save a gif image via
context menu. sometimes you need to save it a second time before you get the
browser to crash, tho.

occurred on winNT and macOS. as an example, try to save one of gif's on the
netcenter homepage.

i'll add the Talkback info as soon as http://cyclone behaves itself (sigh).

Comment 4

[sairuh (rarely reading bugmail)]

for winNT, talkback #7764509:

nsBufferedOutputStream::Flush
[d:\builds\seamonkey\mozilla\netwerk\base\src\nsBufferedStreams.cpp, line 302] 
nsBufferedOutputStream::Close
[d:\builds\seamonkey\mozilla\netwerk\base\src\nsBufferedStreams.cpp, line 269] 
nsStreamXferOp::OnStopRequest
[d:\builds\seamonkey\mozilla\xpfe\components\xfer\src\nsStreamXferOp.cpp, line
434] 
nsHTTPChannel::ResponseCompleted
[d:\builds\seamonkey\mozilla\netwerk\protocol\http\src\nsHTTPChannel.cpp, line
1461] 
nsHTTPServerListener::OnStopRequest
[d:\builds\seamonkey\mozilla\netwerk\protocol\http\src\nsHTTPResponseListener.cpp,
line 497] 
nsOnStopRequestEvent::HandleEvent
[d:\builds\seamonkey\mozilla\netwerk\base\src\nsAsyncStreamListener.cpp, line
286] 
nsStreamListenerEvent::HandlePLEvent
[d:\builds\seamonkey\mozilla\netwerk\base\src\nsAsyncStreamListener.cpp, line
98] 
PL_HandleEvent [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 564] 
PL_ProcessPendingEvents [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c,
line 527] 
_md_EventReceiverProc [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line
1020] 
USER32.dll + 0x1820 (0x77e71820)


for macOS, talkback #7764800 (not very informative):

0x2c030000 
0x0001eea4 
0x00003b00 
0x00009ebc 
0x0000f258 
0x000010a0 
0x0000024c 
PL_HandleEvent() [plevent.c, line 563] 
PL_ProcessPendingEvents() [plevent.c, line 508] 
nsEventQueueImpl::ProcessPendingEvents() [nsEventQueue.cpp, line 314] 
nsMacNSPREventQueueHandler::ProcessPLEventQueue() [nsToolkit.cpp, line 132] 
nsMacNSPREventQueueHandler::RepeatAction() [nsToolkit.cpp, line 97] 
Repeater::DoRepeaters() [nsRepeater.cpp, line 119] 
nsMacMessagePump::DispatchEvent() [nsMacMessagePump.cpp, line 365] 
nsMacMessagePump::DoMessagePump() [nsMacMessagePump.cpp, line 243] 
nsAppShell::Run() [nsAppShell.cpp, line 96] 
0x0000a900 
main1() [nsAppRunner.cpp, line 758] 
main() [nsAppRunner.cpp, line 879] 
.__start 

Comment 5

[sairuh (rarely reading bugmail)]

other note: cannot seem to repro crash saving GIF on linux...

Comment 6

[don]

Bill, is this our bug?

Comment 7

[Eli Goldberg]

Umm...my opinion is that the stack trace looks like that of a Networking bug, but 
I'm sure Bill can figure out where it really belongs.

I can't easily reproduce this problem with other PNG images, after trying a few 
times on <http://www.cdrom.com/pub/png/>.

Comment 8

[sairuh (rarely reading bugmail)]

*** Bug 36594 has been marked as a duplicate of this bug. ***

Comment 9

[leger]

Putting on [nsbeta2+] radar for beta2 fix.

Comment 10

[Bill Law]

PNG/GIF files seem to download OK now (I tried all those mentioned here).  
Subject to limitations described by all the other download bugs, of course.

Comment 11

[sairuh (rarely reading bugmail)]

yep, verif wfm...