Closed
Bug 341453
Opened 18 years ago
Closed 18 years ago
Bugzilla::Series looks for functions in global scope that are not global functions
Categories
(Bugzilla :: Reporting/Charting, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.0
People
(Reporter: mkanat, Assigned: mkanat)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.47 KB,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
Bugzilla::Series is full of stuff like this:
&::ThrowCodeError("invalid_series_id",
ThrowCodeError is not a global function. That is, it's looking for it inside of $main, and it's not actually there--it's in Bugzilla::Error. It does the same with detaint_natural, which lives in Bugzilla::Util.
This only works now because globals.pl imports all of these things into the global scope when it's "required" by each script. But once globals.pl goes away, this breaks (as I just discovered when I removed globals.pl from test-checksetup.pl).
|
Assignee | |
Comment 1•18 years ago
|
||
This seems pretty obviously correct to me.
Attachment #225515 -
Flags: review?(LpSolit)
|
|
Assignee | |
Updated•18 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•18 years ago
|
||
As LpSolit pointed out on IRC, Bugzilla::Series should use Bugzilla::Error.
Attachment #225515 -
Attachment is obsolete: true
Attachment #225517 -
Flags: review?(LpSolit)
Attachment #225515 -
Flags: review?(LpSolit)
|
||
Comment 3•18 years ago
|
||
Comment on attachment 225517 [details] [diff] [review] v2 r=LpSolit
Attachment #225517 -
Flags: review?(LpSolit) → review+
|
|
||
Updated•18 years ago
|
Flags: approval?
|
||
Updated•18 years ago
|
Flags: approval? → approval+
|
|
Assignee | |
Comment 4•18 years ago
|
||
Checking in Bugzilla/Series.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Series.pm,v <-- Series.pm new revision: 1.12; previous revision: 1.11 done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•