34286 - Test directory dependency

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[Joerg.Brunsmann]

If someone wants to build without the test directories
and ./configure --disable-tests you get a compile
error because

xpfe/bootstrap/nsSetupRegistry.cpp

depends on

webshell/tests/viewer/nsSetupRegistry.cpp

Comment 1

[cls]

Using --disable-tests just means that the test directory isn't traversed during
the build.  The source should always be there.  Reassigning to xpcom registry to
see if they are interesting in changing that code.

Comment 2

[Suresh Duddi (gone)]

All this setup registry stuff is xpfe. Bill ?

Comment 3

[Bill Law]

Hmmm.  I don't know anything about that (it evolved a long, long, time ago).  
I'll add this to my collection but I'm not sure that doing something about this 
is a top priority).

Comment 4

[don]

Move to M21 target milestone.

Comment 5

[timeless]

About half of the code referenced in the test file seems needed. I can attach 
my altered version later.  I think it is probably safe to split the two trees 
even though we end up with some code duplication.

Comment 6

[leger]

Updating QA Contact

Comment 7

[Bill Law]

Setting target milestone.

Comment 8

[Jon Henry]

Is this bug still an issue (just going through verifyme bugs...)? I've
successfully built a number of times using --disable-tests in my .mozconfig and
not encountered this error, most recently being 20030914. I'm sorry if I
misunderstand the bug, but this looks like it should become INVALID or WORKSFORME.

Comment 9

[Daniel (Leaf) Nunes]

Release builds are built with --disable-tests, and yes, this issue is no longer
present.

Comment 10

[Tracy Walker [:tracy]]

mass remove verifyme requests greater than 4 months old