344816 - Don't break between ASCII non-space characters in nsPlainTextSerializer/nsHTMLContentSerializer (the long URL is broken at sending mail or copying the text on Thunderbird)

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

This is a regression of bug 255990.

Now, we can break a line between non-ASCII characters. But for nsPlainTextSerializer, this is not good if the format is flowed.

RFC 2646 4.1:

>    A generating agent SHOULD NOT insert white space into a word (a
>    sequence of printable characters not containing spaces).  If faced
>    with a word which exceeds 79 characters (but less than 998
>    characters, the [SMTP] limit on line length), the agent SHOULD send
>    the word as is and exceed the 79-character limit on line length.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

To reproduce, just do a File | Send Page in SeaMonkey (Firefox only has Send Link).

Inside of a multipart/mixed; MIME section, another Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

will break links as such:

http:// weblogs.mozillazine.org/justin/2006/06/

(note the space after the double forward slashes)

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

I created the patch and now testing, please wait a moment.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

I think that we should not *always* break between ASCII characters.
Because even if it's not a flowed format, the URL is broken by CRLF in sending process too (e.g., Japanese lang email).

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

I found two bugs as this behavior.
1. the copy command is broken on Tb.
2. the sending mail source code is broken on Tb.

Both bugs are happen by nsILineBreaker::Prev and nsILineBreaker::Next. I think that we need additional parameter that is whether it allows breaking between latin1.
I'll attach the patch tomorrow.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

Attachment: Patch rv1.0

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

backed-out the original patch. I'll retry to fix it with UAX#14. If you have some ideas and suggestions, please tell me.

-> FIXED(by backed-out)