35119 - popups don't get mouseDown events (but they do get mouseUp/mouseMove/etc)

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[sairuh (rarely reading bugmail)]

spun off from verifying bug 34110, macOS only: i can dropdown the new color
picker, but i'm unable to actually select a color.

1. open up Preferences dialog, select Composer category.
2. dropdown the color picker for any of the items listed under Default Page
Colors.
3. with the mouse, try to click one of the colors to select it.

result: the clicking a color will neither select it nor make it appear in the
swatch associated with the page color item.

note: this might be the result of of color picking not being implemented yet
(see bug 21160 or bug 22952). that, or could pavlov's new picker have broken
something else?

Comment 1

[Stuart Parmenter]

changing summary, adding cc's.  this should probably be reassigned to someone
like pink or saari... dunno who.

Comment 2

[Stuart Parmenter]

*** Bug 35469 has been marked as a duplicate of this bug. ***

Comment 3

[Kathleen :Brade]

not sure who to reassign this bug to; I'll try pinkerton... :-)

Comment 4

[andreww]

In addition to this, after trying the color picker, you cannot type any more text 
into the composer window.  This happens in the AIM compose as well. 

Comment 5

[sairuh (rarely reading bugmail)]

andreww: yep, bug 35100 covers input failure. interesting that AIM's affected as
well. cc'ing syd...

Comment 6

[laurel]

This affects pref for quoting in mail/news messages - found in Mail and
Newsgroups prefs Viewing Messages panel.  cc laurel and pmock for mailnews case

Comment 7

[Peter Trudelle]

Mass-moving all M20-M30 XPToolkit bugs to Future

Comment 8

[Stuart Parmenter]

this should probably be nsbeta2 ;) and not 'future'

Comment 9

[Kathleen :Brade]

Marking this as dogfood; I can set colors on my text with the color picker broken 
(or set preferences, etc.)

Remove milestone (previously set to "future"); we can't ship Mac with a broken 
color picker.

Comment 10

[Stuart Parmenter]

*** Bug 21160 has been marked as a duplicate of this bug. ***

Comment 11

[Stuart Parmenter]

21160 was nsbeta2+, so this bug should be.

Comment 12

[leger]

Putting on [nsbeta2+][dogfood-] radar.  Does not need a fix ASAP for daily work, 
but we should fix this for beta2.

Comment 13

[sairuh (rarely reading bugmail)]

*spam*: transferring current XP Menu bugs over to jrgm, the new component owner.
feel free to add me to the cc list (unless am the Reporter) of any of these, if
you have any questions/etc.

Comment 14

[Mike Pinkerton (not reading bugmail)]

the mouseDown OS event comes in and is redirected w/in the mac widget code in 
nsMacMessagePump::DoMouseDown (case inContent). 

	::SetPortWindowPort(whichWindow);
	if (IsWindowHilited(whichWindow))
		DispatchOSEventToRaptor(anEvent, whichWindow);
	else {
		nsMacWindow *mw = mMessageSink->GetNSWindowFromMacWindow(whichWindow);
		if (mw)
			mw->ComeToFront();
	}

the window isn't hilighted (it's a popup), so it goes into the "else" case. 

i'm testing a few fixes now.

Comment 15

[Mike Pinkerton (not reading bugmail)]

i have a fix, but i'm afraid to check it in for fear of regressing one of danm's 
bugs. will hold my fix until he gets back from vacation.

Comment 16

[Mike Pinkerton (not reading bugmail)]

fixed.

Comment 17

[Mike Pinkerton (not reading bugmail)]

really fixed.

Comment 18

[John Morrison]

verified fixed on mac 2000060608

Comment 19

[Michael Lefevre]

fixing null OS field